backend support for tide dashboard 1.5 - #259
Open
ewollesen wants to merge 9 commits into
Open
Conversation
ewollesen
force-pushed
the
eric-filters-for-tide
branch
from
August 11, 2026 12:30
05221f0 to
3254fce
Compare
Contributor
Author
|
/deploy qa4 |
Collaborator
|
ewollesen updated values.yaml file in qa4 |
Collaborator
|
ewollesen updated flux policies file in qa4 |
Collaborator
|
ewollesen deployed clinic eric-filters-for-tide branch to qa4 namespace |
ewollesen
force-pushed
the
eric-filters-for-tide
branch
from
August 11, 2026 13:14
3254fce to
10b18d7
Compare
ewollesen
force-pushed
the
eric-support-fe-tide-back-4524
branch
from
August 11, 2026 13:14
c183991 to
90144ef
Compare
If a patient in a tide category had a recently disconnected device, it was possible they could appear in both categories.
ewollesen
force-pushed
the
eric-filters-for-tide
branch
2 times, most recently
from
August 26, 2026 15:32
ffc77a0 to
57a11ba
Compare
ewollesen
changed the base branch from
eric-support-fe-tide-back-4524
to
master
August 26, 2026 16:14
ewollesen
changed the title
This was referenced Aug 26, 2026
ewollesen
commented
Aug 26, 2026
|
|
||
| func (r *repository) generateListFilterQuery(filter *patients.Filter) bson.M { | ||
| // ZeroValuesSentinel in a patient-list id filter selects patients with no values assigned. | ||
| const ZeroValuesSentinel = "_" |
Contributor
Author
There was a problem hiding this comment.
This was already being done, but now we're just making it explicit. A matching change is made in TidepoolApi to document what was already happening.
- Hide the demo user from the TIDE report. - Remove some duplicate AfterEach blocks and resultIds blocks in tests.
This filter was being applied on the frontend anyway, but by applying it on the backend, the frontend receives more usable patients to display (i.e. it won't be filtering out half the patients it receives). This is important because there's a limit of 50 patients returned by the backend for performance reasons. This choice to show only Dexcom patients was made originally and approved by product. This Dexcom-specific limitation will be going away in the future when the connection issues dashboard is deployed. BACK-4524
Previously the spec indicated that floating point parameter values for List Patients could include unlimited precision. However, this unlimited precision was not honored by the backend clinic service, which limited the values to 2 decimal places. In addition, the filter denied several common use cases, such as `7` would be rejected for not having a mantissa, while `10.7` would be rejected for having an exponent of more than a single digit. The spec now allows floating point values to have up to 10 digits their exponent and mantissa each respectively. Integers can be specified. BACK-4552
The two concepts are very similar, so making them operate as similarly as possible makes good sense. In this case we're making the definition of sites in the TIDE report look more like tags, but making the Tide.Config response of tags behave more like sites.
ewollesen
force-pushed
the
eric-filters-for-tide
branch
from
September 2, 2026 12:02
57a11ba to
2e52283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of fixes in addition to the new requirements needed to support TIDE dashboard 1.5.
This has been force pushed. Sorry. :/
It has consumed the changes previously in #227, #250, and #251.
BACK-4175
BACK-4251
BACK-4524
BACK-4552