rename the task/service/test package to task/service/taskservicetest

This has a few follow-on effects. Namely one no longer needs to have a special
name for the task/service/test package (previously this was custom named to
"taskServiceTest"). Now it just follows naturally as "taskservicetest" with no
custom naming required.

This change brings the name inline with current Go best practices for package
names and package naming, and also makes it easier for LSP-enabled editors to
automatically manage Go imports. In addition, it follows patterns found in the
Go stdlib (see httptest, slogtest, fstest, iotest, etc.) In general I would
have preferred to keep the name to the concatenation of only two package
names, but "service" is a very common package within platform, so I think it
makes sense to keep all three parts, as otherwise there would be four
"servicetest" packages[^2] and we'd be back to custom renaming the imports
which just makes things harder all around.

[^1]: https://go.dev/doc/effective_go#package-names

[^2]: `$ go list ./... | rg '/(task)?service/?test'`

Author: ewollesen

task/service/api/api_test.go

@@ -11,15 +11,15 @@ import (
 	logTest "github.com/tidepool-org/platform/log/test"
 	taskService "github.com/tidepool-org/platform/task/service"
 	taskServiceApi "github.com/tidepool-org/platform/task/service/api"
-	taskServiceTest "github.com/tidepool-org/platform/task/service/test"
+	"github.com/tidepool-org/platform/task/service/taskservicetest"
 	testRest "github.com/tidepool-org/platform/test/rest"
 )
 
 var _ = Describe("API", func() {
-	var service *taskServiceTest.Service
+	var service *taskservicetest.Service
 
 	BeforeEach(func() {
-		service = taskServiceTest.NewService()
+		service = taskservicetest.NewService()
 	})
 
 	Context("NewRouter", func() {
@@ -60,7 +60,7 @@ var _ = Describe("API", func() {
 				response = testRest.NewResponseWriter()
 				request = testRest.NewRequest()
 				request.Request = request.WithContext(log.NewContextWithLogger(request.Context(), logTest.NewLogger()))
-				service = taskServiceTest.NewService()
+				service = taskservicetest.NewService()
 				var err error
 				router, err = taskServiceApi.NewRouter(service)
 				Expect(err).ToNot(HaveOccurred())

task/service/api/v1/v1_test.go

@@ -8,14 +8,14 @@ import (
 	. "github.com/onsi/gomega/gstruct"
 
 	taskServiceApiV1 "github.com/tidepool-org/platform/task/service/api/v1"
-	taskServiceTest "github.com/tidepool-org/platform/task/service/test"
+	"github.com/tidepool-org/platform/task/service/taskservicetest"
 )
 
 var _ = Describe("V1", func() {
-	var service *taskServiceTest.Service
+	var service *taskservicetest.Service
 
 	BeforeEach(func() {
-		service = taskServiceTest.NewService()
+		service = taskservicetest.NewService()
 	})
 
 	Context("NewRouter", func() {

task/service/test/service.go task/service/taskservicetest/service.gotask/service/test/service.go renamed to task/service/taskservicetest/service.go

@@ -1,4 +1,4 @@
-package test
+package taskservicetest
 
 import (
 	"context"