Repository navigation
fix(core): reject trailing newlines in memory identifiers - #71
Merged
faj-design5260 merged 2 commits intoOct 26, 2026
Merged
faj-design5260 merged 2 commits into
faj-design5260 merged 2 commits into
Conversation
rudycelekli
marked this pull request as ready for review
October 9, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory identity and type identifiers match their complete slug grammar. Trailing newlines cannot create filenames whose identity changes when frontmatter is parsed.
Validation: the added regression fails on upstream and passes with this change. The complete isolated test suite and Ruff pass. Mypy reports the pre-existing OpenRouter assignment error at openrouter.py:327; this change does not claim a clean type-check baseline.
Python3.13 macOS with temporary fixtures; no live provider or host calls; no models installed.