Add some new stuff yeah

Author: timkicker

.github/workflows/build-check.yml

@@ -0,0 +1,62 @@
+name: CI
+
+on:
+  push:
+    branches: [main, dev]
+  pull_request:
+    branches: [main, dev]
+
+jobs:
+  # Native unit tests on Ubuntu — pure C++ logic, no Wii U toolchain needed.
+  tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Configure
+        run: |
+          mkdir -p tests/build
+          cd tests/build
+          cmake .. -DCMAKE_BUILD_TYPE=Release
+
+      - name: Build & run tests
+        run: |
+          cd tests/build
+          make -j$(nproc)
+          ./cupstore_tests
+
+  # Cross-build for both target modes. A regression in either
+  # (e.g. a bug behind #if BUILD_HW) is caught here before merge.
+  build:
+    runs-on: ubuntu-latest
+    container:
+      image: devkitpro/devkitppc:latest
+    strategy:
+      fail-fast: false
+      matrix:
+        mode: [cemu, hw]
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build (${{ matrix.mode }})
+        run: |
+          mkdir -p build
+          cd build
+          cmake .. \
+            -DCMAKE_TOOLCHAIN_FILE=/opt/devkitpro/wut/share/wut.toolchain.cmake \
+            -DBUILD_MODE=${{ matrix.mode }} \
+            -DAPP_VERSION=0.0.0-ci
+          make -j$(nproc)
+
+      - name: Verify wuhb produced
+        run: |
+          test -s build/wiiu_mod_store.wuhb
+          ls -la build/wiiu_mod_store.wuhb
+
+      - name: Upload artifact
+        if: matrix.mode == 'hw' && github.event_name == 'push' && github.ref == 'refs/heads/main'
+        uses: actions/upload-artifact@v4
+        with:
+          name: wiiu_mod_store-${{ matrix.mode }}-${{ github.sha }}
+          path: build/wiiu_mod_store.wuhb
+          retention-days: 14

.github/workflows/ci.yml

@@ -8,8 +8,8 @@
 </p>
 
 <p align="center">
-  <a href="https://github.com/timkicker/coffeeshop/actions">
-    <img alt="CI" src="https://img.shields.io/github/actions/workflow/status/timkicker/coffeeshop/release.yml?label=build">
+  <a href="https://github.com/timkicker/coffeeshop/actions/workflows/ci.yml">
+    <img alt="CI" src="https://img.shields.io/github/actions/workflow/status/timkicker/coffeeshop/ci.yml?branch=main&label=ci">
   </a>
   <a href="https://github.com/timkicker/coffeeshop/releases/latest">
     <img alt="Release" src="https://img.shields.io/github/v/release/timkicker/coffeeshop?display_name=tag&sort=semver">

.github/workflows/test.yml

@@ -112,6 +112,8 @@ bool App::init() {
     pushScreen(std::make_unique<MainLayout>(this));
     elog("after pushScreen");
     CacheManager::cleanupStaleZips();
+    CacheManager::cleanupStalePartials();
+    CacheManager::cleanupStaleStaging();
     CacheManager::cleanupCorruptMods();
     DownloadQueue::get().start();
     ImageCache::get().start();

README.md

@@ -7,6 +7,7 @@
 #include <sys/stat.h>
 #include <unistd.h>
 #include <cstring>
+#include <ctime>
 #include <vector>
 #include <string>
 
@@ -32,6 +33,82 @@ void CacheManager::cleanupStaleZips() {
         LOG_INFO("CacheManager: cleaned up %d stale zip(s)", removed);
 }
 
+void CacheManager::cleanupStalePartials() {
+    std::string dir = Paths::cacheDir();
+    DIR* d = opendir(dir.c_str());
+    if (!d) return;
+
+    int removed = 0;
+    time_t now = time(nullptr);
+    constexpr time_t kMaxAgeSec = 24 * 60 * 60; // 24h
+
+    struct dirent* e;
+    while ((e = readdir(d)) != nullptr) {
+        std::string name = e->d_name;
+        if (name.size() < 8) continue;
+        if (name.substr(name.size() - 8) != ".partial") continue;
+        std::string path = dir + "/" + name;
+        struct stat st;
+        if (stat(path.c_str(), &st) != 0) continue;
+        if (now - st.st_mtime > kMaxAgeSec) {
+            if (remove(path.c_str()) == 0) {
+                LOG_INFO("CacheManager: removed stale .partial: %s", name.c_str());
+                removed++;
+            }
+        }
+    }
+    closedir(d);
+    if (removed > 0)
+        LOG_INFO("CacheManager: cleaned up %d stale partial(s)", removed);
+}
+
+void CacheManager::cleanupStaleStaging() {
+    // 1) Delete every subdirectory of cache/staging.
+    std::string staging = Paths::stagingDir();
+    DIR* d = opendir(staging.c_str());
+    if (d) {
+        int removed = 0;
+        struct dirent* e;
+        while ((e = readdir(d)) != nullptr) {
+            std::string name = e->d_name;
+            if (name == "." || name == "..") continue;
+            if (DownloadManager::rmrf(staging + "/" + name)) removed++;
+        }
+        closedir(d);
+        if (removed > 0)
+            LOG_INFO("CacheManager: cleared %d stale staging entr%s",
+                     removed, removed == 1 ? "y" : "ies");
+    }
+
+    // 2) Delete any "<modid>.old" folders in active sdcafiine paths
+    //    (leftover from a crashed atomic-rename swap).
+    std::vector<std::string> bases = { Paths::sdcafiineBase(), Paths::disabledBase() };
+    for (auto& base : bases) {
+        DIR* td = opendir(base.c_str());
+        if (!td) continue;
+        struct dirent* te;
+        while ((te = readdir(td)) != nullptr) {
+            std::string titleId = te->d_name;
+            if (titleId == "." || titleId == "..") continue;
+            std::string titlePath = base + "/" + titleId;
+            DIR* md = opendir(titlePath.c_str());
+            if (!md) continue;
+            struct dirent* me;
+            while ((me = readdir(md)) != nullptr) {
+                std::string entry = me->d_name;
+                if (entry == "." || entry == "..") continue;
+                if (entry.size() > 4 && entry.substr(entry.size() - 4) == ".old") {
+                    std::string oldPath = titlePath + "/" + entry;
+                    if (DownloadManager::rmrf(oldPath))
+                        LOG_INFO("CacheManager: removed stale .old: %s", oldPath.c_str());
+                }
+            }
+            closedir(md);
+        }
+        closedir(td);
+    }
+}
+
 void CacheManager::cleanupCorruptMods() {
     // Check both active and disabled base dirs
     std::vector<std::string> bases = {

src/app/App.cpp

@@ -7,6 +7,15 @@ class CacheManager {
     // Call once at app startup
     static void cleanupStaleZips();
 
+    // Delete *.zip.partial files older than 24h. Recent partials are kept so
+    // resume-after-restart can pick them up.
+    static void cleanupStalePartials();
+
+    // Delete any subdirectories under Paths::stagingDir() (leftover from a
+    // crash mid-extract) and any "<modid>.old" siblings under sdcafiineBase()
+    // (leftover from a crashed atomic-rename swap).
+    static void cleanupStaleStaging();
+
     // Delete mod folders in sdcafiineBase() and disabledBase() that have no modinfo.json
     // These are left over from a crash during extraction
     static void cleanupCorruptMods();

src/app/CacheManager.cpp

@@ -25,6 +25,13 @@ namespace Paths {
         return modstoreBase() + "/cache";
     }
 
+    // Mods are extracted here first, then atomically renamed into the active
+    // sdcafiine path. Failed extracts never leave half-installed mods in the
+    // active path.
+    inline std::string stagingDir() {
+        return cacheDir() + "/staging";
+    }
+
     inline std::string configFile() {
 #if BUILD_HW
         return modstoreBase() + "/config.json";  // SD card