Align the tooling with the ecosystem standard. (#26)

Author: gustavofreze

.gitattributes

@@ -2,8 +2,6 @@
 
 *.php text diff=php
 
-# Keep Claude tooling scripts out of GitHub's language statistics
-
 # Dev-only, excluded from the Packagist tarball
 /.github             export-ignore
 /tests               export-ignore

.github/PULL_REQUEST_TEMPLATE.md

@@ -12,5 +12,5 @@ Closes #...
 
 - [ ] Tests added or updated.
 - [ ] Documentation updated when applicable.
-- [ ] `composer review` passes.
-- [ ] `composer tests` passes.
+- [ ] `make review` passes.
+- [ ] `make tests` passes.

.github/workflows/ci.yml

@@ -4,49 +4,46 @@ on:
   pull_request:
 
 concurrency:
-  group: pr-${{ github.event.pull_request.number }}
+  group: ci-${{ github.event.pull_request.number }}
   cancel-in-progress: true
 
 permissions:
   contents: read
 
 jobs:
-  resolve-php-version:
-    name: Resolve PHP version
+  resolve-tooling-image:
+    name: Resolve tooling image
     runs-on: ubuntu-latest
     timeout-minutes: 5
     outputs:
-      php-version: ${{ steps.config.outputs.php-version }}
+      php-image: ${{ steps.config.outputs.php-image }}
     steps:
       - name: Checkout
         uses: actions/checkout@v7
 
-      - name: Resolve PHP version from composer.json
+      - name: Resolve tooling image from the Makefile
         id: config
-        run: |
-          version=$(jq -r '.require.php' composer.json | grep -oP '\d+\.\d+' | head -1)
-          echo "php-version=$version" >> "$GITHUB_OUTPUT"
+        run: echo "php-image=$(make show-image)" >> "$GITHUB_OUTPUT"
 
   build:
     name: Build
-    needs: resolve-php-version
+    needs: resolve-tooling-image
     runs-on: ubuntu-latest
     timeout-minutes: 15
+    env:
+      image: ${{ needs.resolve-tooling-image.outputs.php-image }}
+      workspace: /var/www/html
     steps:
       - name: Checkout
         uses: actions/checkout@v7
 
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          tools: composer:2
-          php-version: ${{ needs.resolve-php-version.outputs.php-version }}
-
       - name: Validate composer.json
-        run: composer validate --no-interaction
+        run: docker run --rm -v "${PWD}":${{ env.workspace }} ${{ env.image }} composer validate --no-interaction
 
       - name: Install dependencies
-        run: composer install --no-progress --optimize-autoloader --prefer-dist --no-interaction
+        run: >
+          docker run --rm -v "${PWD}":${{ env.workspace }} ${{ env.image }}
+          composer install --no-progress --optimize-autoloader --prefer-dist --no-interaction
 
       - name: Upload vendor and composer.lock as artifact
         uses: actions/upload-artifact@v7
@@ -58,48 +55,36 @@ jobs:
 
   auto-review:
     name: Auto review
-    needs: [resolve-php-version, build]
+    needs: [resolve-tooling-image, build]
     runs-on: ubuntu-latest
     timeout-minutes: 15
     steps:
       - name: Checkout
         uses: actions/checkout@v7
 
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          tools: composer:2
-          php-version: ${{ needs.resolve-php-version.outputs.php-version }}
-
       - name: Download vendor artifact from build
         uses: actions/download-artifact@v8
         with:
           name: vendor-artifact
           path: .
 
       - name: Run review
-        run: composer review
+        run: make review
 
   tests:
     name: Tests
-    needs: [resolve-php-version, auto-review]
+    needs: [resolve-tooling-image, auto-review]
     runs-on: ubuntu-latest
     timeout-minutes: 15
     steps:
       - name: Checkout
         uses: actions/checkout@v7
 
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          tools: composer:2
-          php-version: ${{ needs.resolve-php-version.outputs.php-version }}
-
       - name: Download vendor artifact from build
         uses: actions/download-artifact@v8
         with:
           name: vendor-artifact
           path: .
 
       - name: Run tests
-        run: composer tests
+        run: make tests

Makefile

@@ -8,7 +8,12 @@ endif
 
 TTY := $(shell [ -t 0 ] && echo -it)
 
-DOCKER_RUN = docker run ${PLATFORM} --rm ${TTY} --net=host -v ${PWD}:/app -w /app gustavofreze/php:8.5-alpine
+PHP_VERSION := $(shell sed -n 's/.*"php": *"^\([0-9]*\.[0-9]*\)".*/\1/p' composer.json)
+IMAGE_VERSION := 1.0.0
+PHP_IMAGE := gustavofreze/php:${PHP_VERSION}-cli-${IMAGE_VERSION}
+WORKSPACE := /var/www/html
+
+DOCKER_RUN = docker run ${PLATFORM} --rm ${TTY} --net=host -v ${PWD}:${WORKSPACE} ${PHP_IMAGE}
 
 RESET := \033[0m
 GREEN := \033[0;32m
@@ -44,6 +49,10 @@ show-reports: ## Open coverage and mutation reports in the browser
 show-outdated: ## Show outdated direct dependencies
 	@${DOCKER_RUN} composer outdated --direct
 
+.PHONY: show-image
+show-image: ## Show the pinned PHP tooling image
+	@echo ${PHP_IMAGE}
+
 .PHONY: clean
 clean: ## Remove dependencies and generated artifacts
 	@sudo chown -R ${USER}:${USER} ${PWD}
@@ -66,7 +75,7 @@ help: ## Display this help message
 		| awk 'BEGIN {FS = ":.*?## "}; {printf "$(YELLOW)%-25s$(RESET) %s\n", $$1, $$2}'
 	@echo ""
 	@echo "$$(printf '$(GREEN)')Reports$$(printf '$(RESET)')"
-	@grep -E '^(show-reports|show-outdated):.*?## .*$$' $(MAKEFILE_LIST) \
+	@grep -E '^(show-reports|show-outdated|show-image):.*?## .*$$' $(MAKEFILE_LIST) \
 		| awk 'BEGIN {FS = ":.*?## "}; {printf "$(YELLOW)%-25s$(RESET) %s\n", $$1, $$2}'
 	@echo ""
 	@echo "$$(printf '$(GREEN)')Cleanup$$(printf '$(RESET)')"

composer.json

@@ -52,6 +52,7 @@
             "ergebnis/composer-normalize": true,
             "infection/extension-installer": true
         },
+        "process-timeout": 0,
         "sort-packages": true
     },
     "scripts": {

phpstan.neon.dist

@@ -3,27 +3,23 @@ parameters:
     paths:
         - src
         - tests
+    tmpDir: reports/phpstan
     ignoreErrors:
         # Order fixture stores arbitrary arrays for structural-equality tests.
         - identifier: missingType.iterableValue
           path: tests/Models/Order.php
-
         # Internal array-equality collaborator accepts arrays with arbitrary value types by design.
         - identifier: missingType.iterableValue
           path: src/Internal/ArrayEquality.php
-
         # Internal array-hash collaborator accepts arrays with arbitrary value types by design.
         - identifier: missingType.iterableValue
           path: src/Internal/ArrayHash.php
-
         # Internal property extractor returns an untyped array by design; PHPDoc is prohibited in Internal/.
         - identifier: missingType.iterableValue
           path: src/Internal/ObjectProperties.php
-
         # Private properties are read via reflection; PHPStan cannot trace reflection-based access.
         - identifier: property.onlyWritten
           path: tests/Models/PrivateMoney.php
-
         # Private property is read via reflection; PHPStan cannot trace reflection-based access.
         - identifier: property.onlyWritten
           path: tests/Models/MixedVisibilityProfile.php