Skip to content

fix: use search_btn to match GraphQL query attribute name in template_async.py - #170

Open
Jah-yee wants to merge 1 commit into
tinyfish-io:mainfrom
Jah-yee:fix/search-btn-attribute-name
Open

Jah-yee wants to merge 1 commit into
tinyfish-io:mainfrom
Jah-yee:fix/search-btn-attribute-name

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Oct 1, 2026

Copy link
Copy Markdown

Summary

In .templates/python/template_async.py, the GraphQL query defines the search button as search_btn (line 42), but the element interaction code used search_button (line 50). This caused an AttributeError at runtime since AgentQL's response object dynamically creates attributes matching the query keys.

Fix

Change search_button → search_btn to match the query definition.

The search_btn name is also used correctly in template_sync.py (line 43), confirming this is the intended name.

Closes #162.

In template_async.py, the GraphQL query defines the search button
as 'search_btn' (line 42), but the element interaction code used
'search_button' (line 50). This caused an AttributeError at runtime
since AgentQL's response object creates attributes matching query keys.

Change 'search_button' to 'search_btn' to match the query definition.

Fix tinyfish-io#162.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e33d8a9a-98b7-45bb-a55c-145d99cdc426

📥 Commits

Reviewing files that changed from the base of the PR and between e1f237b and 44053fe.

📒 Files selected for processing (1)
  • .templates/python/template_async.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The async Python template now calls response.search_btn.click(). This matches the search_btn identifier declared in the element query.

Priority: ⬇️ Low

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 44053

The async template now uses the search-button identifier declared by its query, with no remaining merge-blocking concern.

Architecture Summary

Architecture risk: 🔵 Low · up to 44053

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .templates/python/template_async.py: fetch_data now clicks search_btn instead of search_button.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the attribute-name fix in template_async.py and matches the main change.
Description check ✅ Passed The description accurately explains the attribute mismatch, runtime error, fix, and related template_sync.py reference.
Linked Issues check ✅ Passed Issue #162 requires template_async.py to use response.search_btn for the query key search_btn. The PR summary states that it changes response.search_button.click() to `response.search_btn.clic…
Out of Scope Changes check ✅ Passed The available PR summary reports one change in .templates/python/template_async.py. The change directly implements issue #162. No unrelated change is identified.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@Jah-yee

Jah-yee commented Oct 9, 2026

Copy link
Copy Markdown
Author

Friendly ping — any updates? Happy to address feedback.

2 similar comments
@Jah-yee

Jah-yee commented Oct 16, 2026

Copy link
Copy Markdown
Author

Friendly ping — any updates? Happy to address feedback.

@Jah-yee

Jah-yee commented Oct 17, 2026

Copy link
Copy Markdown
Author

Friendly ping — any updates? Happy to address feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolve AttributeError typo in python async template (search_btn)

1 participant