test: skip finalizerinvariants.go on riscv-qemu - #5680
Closed
deadprogram wants to merge 1 commit into
Closed
deadprogram wants to merge 1 commit into
deadprogram wants to merge 1 commit into
Conversation
The finalizer code stops or fails on multicore RISC-V. Locally, 10 of 100 runs fail. 5 runs stop, with one hart in runGC and the other harts in schedulerUnlockAndWait. 5 runs fail with mcause=5 in runtime.scanConservative. Skip the test on this target until tinygo-org#5679 is corrected.
deadprogram
force-pushed
the
skip-finalizerinvariants-riscv
branch
from
September 13, 2026 10:07
6c8c353 to
c8be5c3
Compare
Member
Author
|
Closed. PR #5681 replaces this one. The branch is now in the tinygo-org repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
TestBuild/EmulatedRISCV/finalizerinvariants.gofails sometimes in CI. The run stops and the 2m timeout givescontext deadline exceeded. See https://github.com/tinygo-org/tinygo/actions/runs/34747497323/job/103697999692CI speed is not the cause. I ran the same binary locally with the same qemu command. 10 of 100 runs failed. A good run takes approximately 0.9s. 5 runs stopped and did not continue. 5 runs failed with
mcause=5, which is a load access fault, inruntime.scanConservative. In one stopped run, one hart was inruntime.runGCand the other three harts were inruntime.schedulerUnlockAndWait. Thus the stop-the-world operation does not complete. The testtestdata/gc.gopassed 40 of 40 runs on the same target. Thus the fault is in the finalizer code withscheduler=cores.A longer timeout does not correct this, because the run stops for an unlimited time, and the faults occur again.
This change skips the test on
riscv-qemu, near the same skip forsimavr. Issue #5679 contains the full data and the procedure to cause the fault. Remove this skip when #5679 is corrected.