added 401 and 403 to expected UpnpReponsed issue #232

Author: tobexyz

yaacc/src/main/java/org/fourthline/cling/model/message/UpnpResponse.java

@@ -26,6 +26,8 @@ public static enum Status {
 
         OK(200, "OK"),
         BAD_REQUEST(400, "Bad Request"),
+        UNAUTHORIZED(401, "Unauthorized"),
+        FORBIDDEN(403, "Forbidden"),
         NOT_FOUND(404, "Not Found"),
         METHOD_NOT_SUPPORTED(405, "Method Not Supported"),
         PRECONDITION_FAILED(412, "Precondition Failed"),

yaacc/src/test/java/de/yaacc/upnp/server/http/HttpRequestSenderTest.java

@@ -18,6 +18,11 @@
  */
 package de.yaacc.upnp.server.http;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+
 import org.apache.hc.core5.http.ContentType;
 import org.apache.hc.core5.http.io.entity.ByteArrayEntity;
 import org.apache.hc.core5.http.message.BasicClassicHttpResponse;
@@ -26,11 +31,6 @@
 
 import java.nio.charset.StandardCharsets;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
-
 public class HttpRequestSenderTest {
 
     @Test
@@ -70,11 +70,25 @@ public void testCreateResponse_401_doesNotThrow() throws Exception {
         StreamResponseMessage msg = new HttpRequestSender().createResponse(buildResponse(401, "Unauthorized"));
         assertNotNull(msg);
         assertEquals(401, msg.getOperation().getStatusCode());
-        assertEquals("HTTP 401", msg.getOperation().getStatusMessage());
+        assertEquals("Unauthorized", msg.getOperation().getStatusMessage());
         assertTrue("401 must report isFailed() so the discovery loop skips the device",
                 msg.getOperation().isFailed());
     }
 
+    /**
+     * Regression for issue #232. A 403 produce a synthetic failed
+     * UpnpResponse so the caller can skip the device.
+     */
+    @Test
+    public void testCreateResponse_403_doesNotThrow() throws Exception {
+        StreamResponseMessage msg = new HttpRequestSender().createResponse(buildResponse(403, "Forbidden"));
+        assertNotNull(msg);
+        assertEquals(403, msg.getOperation().getStatusCode());
+        assertEquals("Forbidden", msg.getOperation().getStatusMessage());
+        assertTrue("403 must report isFailed() so the discovery loop skips the device",
+                msg.getOperation().isFailed());
+    }
+
     /**
      * Regression for issue #219 / PR #221. 503 was added to the canonical
      * Status enum in that PR; verify it still maps to the canonical