Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fit a 6x7 plate on a P1S having a max capacity of 6x6 resulted in wrong calculations.
maxBedUnitsX 6 maxBedUnitsY 6
xUnits 7 yUnits 5
mainPartXUnits 6 mainPartYUnits 5
mainPartCountX 1 mainPartCountY 1
sparePartUnitsX 1 sparePartUnitsY 5
The sparePartUnits does not fully take into account the main part.
With the new formula if the plate fully fits in a direction (examples with x, same for y):
xUnits <= maxBedUnitsX
-> mainPartXUnits = xUnits
-> xUnits - mainPartXUnits = 0
-> no additional spare parts
This now gives
maxBedUnitsX 6 maxBedUnitsY 6
xUnits 7 yUnits 5
mainPartXUnits 6 mainPartYUnits 5
mainPartCountX 1 mainPartCountY 1
sparePartUnitsX 1 sparePartUnitsY 0