Fix ansible linting warnings

Author: tomodachi

roles/dns_over_tls/tasks/main.yml

@@ -3,13 +3,13 @@
 - name: Detect arch for cloudflare deb
   ansible.builtin.command:
     cmd: dpkg --print-architecture
-  register: os_arch
+  register: dns_over_tls_os_arch
   changed_when: false
   check_mode: false
 
 - name: Download DNS over TLS Cloudflared
   ansible.builtin.get_url:
-    url: "{{ cloudflared_release_ver }}{{ cloudflared_release_arch[os_arch.stdout] }}"
+    url: "{{ cloudflared_release_ver }}{{ cloudflared_release_arch[dns_over_tls_os_arch.stdout] }}"
     dest: /tmp/cloudflared.deb
     owner: root
     group: root

roles/dns_over_tls/vars/main.yml

@@ -1,13 +1,13 @@
 ---
 # Cloudflare DNS related settings
-cloudflared_release_ver: https://github.com/cloudflare/cloudflared/releases/download/2025.2.1/
+dns_over_tls_cloudflared_release_ver: https://github.com/cloudflare/cloudflared/releases/download/2025.2.1/
 
-cloudflared_release_arch:
+dns_over_tls_cloudflared_release_arch:
   amd64: cloudflared-linux-amd64.deb
   arm64: cloudflared-linux-arm64.deb
   armhf: cloudflared-linux-armhf.deb
 
-doh_dns_1: "base.dns.mullvad.net"
+dns_over_tls_doh_dns_1: "base.dns.mullvad.net"
 
-packages:
+dns_over_tls_packages:
   - dnsmasq

roles/firewall/tasks/main.yml

@@ -0,0 +1,49 @@
+---
+
+- name: Install packages
+  ansible.builtin.package:
+    name: "{{ firewall_packages }}"
+
+- name: Copy in VLAN NIC setup script
+  ansible.builtin.template:
+    src: vlan-nic-setup.j2
+    dest: /usr/local/bin/vlan-setup.sh
+    owner: root
+    group: root
+    mode: '0700'
+
+- name: Template dnsmasq config
+  ansible.builtin.template:
+    src: dnsmasq.conf.j2
+    dest: /etc/dnsmasq.d/homenet.conf
+    owner: root
+    group: root
+    mode: '0600'
+  notify:
+    - Restart dnsmasq
+  tags: dnsmasq
+
+- name: Enable IP forwarding
+  ansible.posix.sysctl:
+    name: net.ipv4.ip_forward
+    value: '1'
+    sysctl_set: true
+    state: present
+    reload: true
+
+- name: Template nftables FW rules
+  ansible.builtin.template:
+    src: nftables.conf.j2
+    dest: /etc/nftables.conf
+    owner: root
+    group: root
+    mode: '0700'
+  tags: nftables
+  notify:
+    - Reload nftables
+
+- name: Enable nftables service
+  ansible.builtin.systemd:
+    name: nftables
+    state: started
+    enabled: true

roles/firewall/vars/main.yml

@@ -0,0 +1,4 @@
+---
+
+firewall_packages:
+  - dnsmasq

roles/single_nic_firewall/tasks/main.yml

@@ -2,7 +2,7 @@
 
 - name: Install packages
   ansible.builtin.package:
-    name: "{{ packages }}"
+    name: "{{ single_nic_firewall_packages }}"
 
 - name: Copy in VLAN NIC setup script
   ansible.builtin.template:

roles/single_nic_firewall/vars/main.yml

@@ -1,4 +1,4 @@
 ---
 
-packages:
+single_nic_firewall_packages:
   - dnsmasq

roles/steamlink_pi/tasks/main.yml

@@ -6,12 +6,11 @@
 - name: Install required dependencies for steamlink
   become: true
   ansible.builtin.package:
-    name: "{{ steamlink_dependencies }}"
+    name: "{{ steamlink_pi_steamlink_dependencies }}"
 
-- name: Create sixpairing folder for ps3 controller support
-  become: true
   ansible.builtin.file:
-    path: "/root/{{ sixpairfolder }}"
+  become: true
+    path: "/root/{{ steamlink_pi_sixpairfolder }}"
     state: directory
     owner: root
     group: root
@@ -20,9 +19,9 @@
 - name: Download ps3pairing utils aka sixadd
   become: true
   ansible.builtin.git:
-    repo: "{{ sixad }}"
-    dest: "/root/{{ sixpairfolder }}/"
-    version: "{{ sixad_tag_version }}"
+    repo: "{{ steamlink_pi_sixad }}"
+    dest: "/root/{{ steamlink_pi_sixpairfolder }}/"
+    version: "{{ steamlink_pi_sixad_tag_version }}"
 
 - name: Compile sixadd
   become: true

roles/steamlink_pi/vars/main.yml

@@ -1,10 +1,10 @@
 ---
 
-sixpairfolder: sixad
-sixad: https://github.com/RetroPie/sixad
-sixad_tag_version: "1.6.0"
+steamlink_pi_sixpairfolder: sixad
+steamlink_pi_sixad: https://github.com/RetroPie/sixad
+steamlink_pi_sixad_tag_version: "1.6.0"
 
-steamlink_dependencies:
+steamlink_pi_steamlink_dependencies:
   - steamlink
   - build-essential
   - libusb-dev

roles/tftpd_server/tasks/main.yml

@@ -3,7 +3,7 @@
 - name: Install packages
   become: true
   ansible.builtin.package:
-    name: "{{ packages }}"
+    name: "{{ tftpd_server_packages }}"
     state: present
 
 - name: Configure NFS export for root and boot
@@ -27,4 +27,4 @@
     name: "{{ item }}"
     state: started
     enabled: true
-  loop: "{{ packages }}"
+  loop: "{{ tftpd_server_packages }}"

roles/tftpd_server/vars/main.yml

@@ -1,4 +1,4 @@
 ---
-packages:
+tftpd_server_packages:
   - tftpd-hpa
   - nfs-kernel-server