[WIP] [standalone] Dimension reduction standalone module, and a few dimension reduction changes - #998
Draft
atalon-lip6 wants to merge 7 commits into
Draft
[WIP] [standalone] Dimension reduction standalone module, and a few dimension reduction changes#998atalon-lip6 wants to merge 7 commits into
atalon-lip6 wants to merge 7 commits into
Conversation
atalon-lip6
force-pushed
the
standalone-dimred
branch
from
December 7, 2023 15:08
113c9f5 to
5ed2f44
Compare
atalon-lip6
force-pushed
the
standalone-dimred
branch
from
December 7, 2023 15:16
5ed2f44 to
21ec12e
Compare
atalon-lip6
force-pushed
the
standalone-dimred
branch
from
December 7, 2023 16:13
21ec12e to
509d2c4
Compare
julien-tierny
requested changes
Dec 18, 2023
julien-tierny
left a comment
julien-tierny
left a comment
Collaborator
There was a problem hiding this comment.
thanks a lot
here's a first batch of remarks.
| } | ||
| } | ||
|
|
||
| return 0; |
Collaborator
There was a problem hiding this comment.
note for later: there's still a segfault upon the program termination.
Contributor
Author
There was a problem hiding this comment.
I fixed this by running Py_Finalize in the destruction of dimensionReduction.
In the previous version we would not run it if Python was already initialized, I mimick this behaviour with an additional boolean member of dimensionReduction.
Note: not sure if it is normal, but valgrind says some things initialised by Python are not freed. Yet, Py_Finalized is called.
atalon-lip6
force-pushed
the
standalone-dimred
branch
from
December 24, 2023 17:18
a79e229 to
c8a4647
Compare
atalon-lip6
force-pushed
the
standalone-dimred
branch
from
December 24, 2023 17:25
c8a4647 to
8400b75
Compare
julien-tierny
changed the title
julien-tierny
changed the title
julien-tierny
marked this pull request as draft
June 27, 2024 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the dimension reduction standalone command-line module. It also adds some documentations for options of dimension reduction in the xml file. It finally reflects a change in a default options for tsne embedding in the base code.