Fix Windows installer stamping itself as beta.3 (#10)

Codex reported: installer/windows/setup.iss's MyAppVersion -- baked
into the built .exe as its AppVersion, visible in Windows' Programs &
Features and the installer's own properties -- was still 0.1.0-beta.3
after v0.1.0-beta.4 was tagged and released. The advertised beta.4
download would therefore install and register itself as beta.3,
misleading for version reporting and upgrade diagnosis.

Bump MyAppVersion to 0.1.0-beta.4. Add a regression test
cross-checking it against docs/index.html's JSON-LD softwareVersion
field -- there's no single VERSION file in this repo, so this catches
future drift without introducing new shared state.

Author: tradewithmeai

CHANGELOG.md

@@ -151,6 +151,14 @@ installation and successfully launches Socials Studio -- see README.md's Testing
 
 ### Fixed
 
+- **The Windows installer stamped itself as beta.3 after v0.1.0-beta.4 was released.** Reported by
+  Codex review: `installer/windows/setup.iss`'s `MyAppVersion` -- baked into the built `.exe` as
+  its `AppVersion`, visible in Windows' Programs & Features and the installer's own properties --
+  was left at `0.1.0-beta.3`, so the advertised beta.4 download would install and register itself
+  as beta.3, misleading for version reporting and upgrade diagnosis. Fixed by bumping
+  `MyAppVersion` to `0.1.0-beta.4`. Added a regression test cross-checking it against
+  `docs/index.html`'s JSON-LD `softwareVersion` field, since there's no single VERSION file in this
+  repo to check against instead.
 - **Linux setup no longer mistakes Chromium for the required Google Chrome.** Reported by Codex
   review: `installer/bootstrap.py`'s Linux Chrome detection accepted `chromium` and
   `chromium-browser` in addition to real Chrome executable names, but

installer/windows/setup.iss

@@ -50,7 +50,7 @@
 ; succeeded is reported from the real CI run, not asserted in this comment.
 
 #define MyAppName "Socials Studio"
-#define MyAppVersion "0.1.0-beta.3"
+#define MyAppVersion "0.1.0-beta.4"
 #define MyAppPublisher "Socials Studio (independent, community project)"
 #define MyAppURL "https://github.com/tradewithmeai/socials-studio"
 #ifndef MyOutputBaseFilename

tests/test_installer_setup_iss.py

@@ -8,14 +8,24 @@
 "IPersistFile::Save failed; code 0x80070005. Access is denied." targeting
 "C:\\Users\\Public\\Desktop\\Socials Studio.lnk". {userdesktop} (the current
 user's own desktop) never has that problem.
+
+Also guards against a Codex-reported regression: setup.iss's MyAppVersion
+(baked into the built .exe as its AppVersion) was left at "0.1.0-beta.3"
+after v0.1.0-beta.4 was tagged and released, so the advertised beta.4
+download would have installed and registered itself as beta.3 -- misleading
+for version reporting and upgrade diagnosis. There's no single VERSION file
+in this repo; the version string is repeated across a few files, so this
+test cross-checks setup.iss against docs/index.html's machine-readable
+JSON-LD softwareVersion field rather than introducing new shared state.
 """
 from __future__ import annotations
 
+import re
 from pathlib import Path
 
-SETUP_ISS = (
-    Path(__file__).resolve().parent.parent / "installer" / "windows" / "setup.iss"
-).read_text(encoding="utf-8")
+REPO_ROOT = Path(__file__).resolve().parent.parent
+SETUP_ISS = (REPO_ROOT / "installer" / "windows" / "setup.iss").read_text(encoding="utf-8")
+DOCS_INDEX_HTML = (REPO_ROOT / "docs" / "index.html").read_text(encoding="utf-8")
 
 
 def test_privileges_required_is_lowest():
@@ -66,3 +76,25 @@ def test_desktopicon_task_still_declared():
     """The `desktopicon` task itself (which makes the shortcut opt-in, not
     automatic) must still exist."""
     assert 'Name: "desktopicon"' in SETUP_ISS
+
+
+def test_installer_version_matches_docs_index_software_version():
+    """Regression test for the Codex-reported version-drift bug: setup.iss's
+    MyAppVersion is baked into the built .exe's AppVersion (visible in
+    Windows' Programs & Features / installer properties). If it isn't bumped
+    alongside a release, the advertised binary silently installs and
+    registers itself as an older version. docs/index.html's JSON-LD
+    softwareVersion field is a machine-readable version marker already
+    expected to track the current release, so cross-checking against it
+    catches this drift without introducing a new shared VERSION file."""
+    iss_match = re.search(r'#define MyAppVersion "([^"]+)"', SETUP_ISS)
+    assert iss_match, "MyAppVersion not found in setup.iss"
+
+    docs_match = re.search(r'"softwareVersion":\s*"([^"]+)"', DOCS_INDEX_HTML)
+    assert docs_match, "softwareVersion not found in docs/index.html"
+
+    assert iss_match.group(1) == docs_match.group(1), (
+        f"installer/windows/setup.iss's MyAppVersion ({iss_match.group(1)!r}) does not match "
+        f"docs/index.html's softwareVersion ({docs_match.group(1)!r}) -- the built Windows "
+        "installer would install and register itself as the wrong version."
+    )