Fix Windows installer stamping itself as beta.3 - #10
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codex reported: installer/windows/setup.iss's MyAppVersion -- baked into the built .exe as its AppVersion, visible in Windows' Programs & Features and the installer's own properties -- was still 0.1.0-beta.3 after v0.1.0-beta.4 was tagged and released. The advertised beta.4 download would therefore install and register itself as beta.3, misleading for version reporting and upgrade diagnosis. Bump MyAppVersion to 0.1.0-beta.4. Add a regression test cross-checking it against docs/index.html's JSON-LD softwareVersion field -- there's no single VERSION file in this repo, so this catches future drift without introducing new shared state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex flagged (P2) that the Windows installer built for
v0.1.0-beta.4would install and registeritself as
0.1.0-beta.3:installer/windows/setup.iss'sMyAppVersion-- which the build bakesinto the compiled
.exe'sAppVersion(visible in Windows' Programs & Features and theinstaller's own properties) -- was never bumped past
0.1.0-beta.3, even though the releaseworkflow builds the executable by invoking
iscc installer\windows\setup.issfor the taggedrelease. This makes version reporting and future upgrade diagnosis misleading.
Fix
MyAppVersionfrom0.1.0-beta.3to0.1.0-beta.4.tests/test_installer_setup_iss.py) that cross-checkssetup.iss'sMyAppVersionagainstdocs/index.html's JSON-LDsoftwareVersionfield. There's no singleVERSION file in this repo (the version string is repeated across a handful of files), so this
catches the two most load-bearing copies drifting apart again without introducing new shared
state.
Unreleased/Fixedchangelog entry.Validation
pytest-- 108 passed (was 107 before this PR)python -m compileall -q auth installer doctor.py tests-- cleangit diff --check-- cleanprofiles/touched