feat(chart): 📝 version support with annotations - #1791
Conversation
f434cc7 to
15291dd
Compare
mloiseleur
left a comment
There was a problem hiding this comment.
First review.
- Changelog is not updated as expected.
- Tests on notes.txt will probably annoy us. Wdyt of reducing and/or simplifying them ?
5c84045 to
72c0ad7
Compare
72c0ad7 to
4c0a34d
Compare
4c0a34d to
2f35b27
Compare
|
Thanks for the revie @mloiseleur. Here my changes to address your comments:
|
That seems very high. We have between 2 and 20 PRs for a single release. |
|
| set -e | ||
|
|
||
| /usr/bin/helm unittest --color ./traefik | ||
| # Test against a copy of the traefik chart with pinned version-support |
There was a problem hiding this comment.
Seems a bit excessive to copy everything when we need here to set specific value for consistent test.
Wdyt about:
- Open an issue on https://github.com/helm-unittest/helm-unittest about the capacity to set this kind of field
- Explore if we can use postRenderer to avoid this
- Use helm plugin install of docker, so it could at least be done in place, by saving current values and restoring them afterwards (example here)
There was a problem hiding this comment.
- yes this is the long-term response to this problem
- postRenderer transforms the output but not the evaluation of templates (cf. https://github.com/helm-unittest/helm-unittest/blob/main/pkg/unittest/test_job.go#L491; TLDR if statements are evaluated at rendering time)
- done in 0fcd9c8
50e4ed3 to
69f5105
Compare
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
69f5105 to
77f8e45
Compare
What does this PR do?
Declares supported Traefik Proxy and Hub version ranges as Chart.yaml annotations
(
traefik.io/proxy-min-version,proxy-max-version,hub-min-version,hub-max-version),replacing hardcoded values in templates.
Motivation
Fixes #1758
More
make testand all the tests passed