feat(ingressClass): make controller value configurable - #1976
Closed
asamudrala1 wants to merge 1 commit into
Closed
Conversation
Allow users to override the IngressClass controller value via values.yaml. This enables running multiple Traefik instances with isolated IngressClass routing in the same cluster. Previously, the controller value was hardcoded as 'traefik.io/ingress-controller', preventing proper traffic segregation between multiple Traefik instances. Changes: - Add 'controller' field to ingressClass values with default 'traefik.io/ingress-controller' - Update IngressClass template to use configurable controller value - Add tests for default and custom controller values - Update values.schema.json to include new controller property Fixes: #13733
Member
|
See #1645 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the IngressClass controller value configurable via
values.yaml, enabling users to run multiple Traefik instances with isolated IngressClass routing in the same cluster.Problem
Currently, the IngressClass controller value is hardcoded as
traefik.io/ingress-controllerin the Helm chart template. This prevents users from running multiple Traefik instances (e.g., Internal and External) with proper traffic segregation, as both instances discover and process ALL ingresses regardless of the IngressClass name.Fixes #13733
Solution
Added a new
ingressClass.controllerfield invalues.yamlwith a default value oftraefik.io/ingress-controllerto maintain backward compatibility. Users can now override this value to create unique controller identifiers for each Traefik instance.Changes
controllerfield toingressClasssection with default value and documentation{{ .Values.ingressClass.controller }}instead of hardcoded valuecontrollerproperty with appropriate schema definitionExample Usage
Default Behavior (Backward Compatible)
Multiple Traefik Instances with Isolated Routing
With this change, each Traefik instance will only process ingresses that reference its specific IngressClass, enabling proper traffic segregation.
Testing
Checklist
Related Issues