Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #4460
Same shape as #4334, but for
CLIENT_IGNORE_SPACE. This addsMySqlConnectOptions::ignore_space(bool), and only sets the capability when it's enabled. I went ahead and put this up alongside the issue since it's small, happy to rework it if you'd rather go a different direction.The test checks that the server reflects the flag in the session's
sql_mode, and thatCOUNT (*)parses with the default and fails withignore_space(false). It fails without the change toMySqlStream::with_socket.Is this a breaking change?
No. The default is
true, which is the current behavior.