Skip to content

Commit b42c2b6

Browse files
committed
Explain the expected way to run upgradecopy. Clarify other messages.
1 parent 2b933e7 commit b42c2b6

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

apt-cyg

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -756,9 +756,6 @@ apt_mirror () {
756756
fi
757757
}
758758

759-
# TODO: Run upgrade from the actual root. Include prepupgrade into it as well.
760-
# Use the other root as a prefix in all functions.
761-
762759
apt_upgradesetup() {
763760
local preproot
764761
preproot=/fw
@@ -768,7 +765,7 @@ apt_upgradesetup() {
768765
fi
769766
if [ "${preproot}" = "/" ]
770767
then
771-
error "prepupgrade needs a separate root" || return 1
768+
error "upgradesetup needs a separate root" || return 1
772769
fi
773770
if [ -d "${preproot}" ]
774771
then
@@ -814,7 +811,7 @@ apt_upgradeinstall() {
814811
fi
815812
if [ "${preproot}" = "/" ]
816813
then
817-
error "prepupgrade needs a separate root" || return 1
814+
error "upgradeinstall needs a separate root" || return 1
818815
fi
819816
preprootnative=$(cygpath -wa "${preproot}")
820817

@@ -841,7 +838,12 @@ apt_upgradecopy() {
841838
fi
842839
if [ ! "$origroot" ]
843840
then
844-
error "Could not find a reference to the actual root that needs creating with apt-cyg prepupgrade" || return 1
841+
error "Could not find the primary root reference created with apt-cyg upgradesetup.
842+
The upgradecopy command needs running from Command Prompt using the shell copied to
843+
a secondary root, e.g.
844+
845+
c:\cygwin64\fw\bin\ash.exe /bin/apt-cyg upgradecopy
846+
" || return 1
845847
fi
846848
local winsys
847849
winsys=$(cygpath -S)
@@ -928,7 +930,7 @@ apt_upgradecomplete() {
928930
/bin/echo -E "Cleaning up the secondary root ${preproot} ..."
929931
rm -rf "${preproot}"
930932
931-
echo "Cleaning up files stashed by the upgrade in /bin.bak, /usr.bak, /etc.bak ...."
933+
echo "Cleaning up files stashed by the upgrade in /{bin,usr,etc,sbin,lib,var}.bak ..."
932934
rm -rf /bin.bak /usr.bak /etc.bak /sbin.bak /lib.bak /var.bak
933935
}
934936

0 commit comments

Comments
 (0)