Add linting to CI/CD pipeline
Problem
Currently, our GitHub Actions CI/CD pipeline only runs tests but doesn't include linting checks. This means code style and linting issues can be merged into the main branch without being caught.
Current CI/CD steps:
- ✅ npm ci
- ✅ npm run build
- ✅ npm test
- ❌ No linting step
Solution
Add linting to the existing .github/workflows/tests.yml workflow to ensure code quality standards are enforced.
Suggested addition:
This should be added after the build step but before the test step to catch linting issues early.
Benefits
- Code quality enforcement: Prevent style inconsistencies from being merged
- Early feedback: Developers get linting feedback in PRs before merge
- Consistency: Ensures all code follows the same style guidelines across contributors
- Automated enforcement: Removes manual review burden for style issues
Implementation
The project already has linting configured:
- Command:
npm run lintFull
- Tools: Prettier + ESLint with TypeScript support
- Config: Uses
eslint-config-rickschubert and custom prettier settings
Just need to add the linting step to the CI workflow.
Priority
Medium - This improves code quality and developer experience but doesn't block current functionality.
Add linting to CI/CD pipeline
Problem
Currently, our GitHub Actions CI/CD pipeline only runs tests but doesn't include linting checks. This means code style and linting issues can be merged into the main branch without being caught.
Current CI/CD steps:
Solution
Add linting to the existing
.github/workflows/tests.ymlworkflow to ensure code quality standards are enforced.Suggested addition:
This should be added after the build step but before the test step to catch linting issues early.
Benefits
Implementation
The project already has linting configured:
npm run lintFulleslint-config-rickschubertand custom prettier settingsJust need to add the linting step to the CI workflow.
Priority
Medium - This improves code quality and developer experience but doesn't block current functionality.