Skip to content

build: Update C++ standard from c++17 to c++20 - #311

Open
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1877/TRI-1855-std-20
Open

build: Update C++ standard from c++17 to c++20#311
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1877/TRI-1855-std-20

Conversation

@mc-nv

@mc-nv mc-nv commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

What does the PR do?

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • src/CMakeLists.txt - src/dali_executor/CMakeLists.txt

Test plan:

  • CI Pipeline ID: 67062220

Caveats:

This repo has no direct dependency on ATen/libtorch; the bump is for cross-repo C++ standard consistency, not a confirmed build break here.

Background

Part of a coordinated C++17->C++20 bump across ~18 Triton component repos (TRI-1877), triggered by upstream PyTorch's ATen.h now requiring C++20.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Resolves: TRI-1877

Upstream PyTorch raised ATen's minimum required C++ standard from 17
to 20 (pytorch/pytorch#178150), which broke the pytorch_backend build.
Align this repo's CXX_STANDARD/CUDA_STANDARD default with that floor
for consistency across the stack.

TRI-1877
@mc-nv mc-nv self-assigned this Sep 9, 2026
@mc-nv mc-nv added the build Build system or external dependencies (build: PRs) label Sep 9, 2026
This was referenced Sep 9, 2026
@mc-nv
mc-nv requested review from JanuszL and banasraf September 9, 2026 23:12
@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [67108824]: BUILD STARTED

@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [67108824]: BUILD PASSED

@JanuszL JanuszL self-assigned this Sep 10, 2026
@mc-nv
mc-nv marked this pull request as ready for review September 10, 2026 15:28
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because all repository-owned C++ targets are updated consistently and no concrete compatibility or propagation defect remains.

Summary

  • Updates the backend utility, shared backend, and unit-test targets.
  • Updates the DALI executor target.
  • Leaves dependency acquisition, packaging, and runtime behavior unchanged.

Reviews (1) · Last reviewed commit: "build: Update C++ standard from c++17 to..."

@mc-nv
mc-nv requested a review from yinggeh September 10, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or external dependencies (build: PRs)

Development

Successfully merging this pull request may close these issues.

3 participants