Skip to content

build: Update C++ standard from c++17 to c++20 - #455

Merged
mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1877/TRI-1855-std-20
Sep 11, 2026
Merged

build: Update C++ standard from c++17 to c++20#455
mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1877/TRI-1855-std-20

Conversation

@mc-nv

@mc-nv mc-nv commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • CMakeLists.txt

Test plan:

  • CI Pipeline ID: 67062220

Caveats:

This repo has no direct dependency on ATen/libtorch; the bump is for cross-repo C++ standard consistency, not a confirmed build break here.

Background

Part of a coordinated C++17->C++20 bump across ~18 Triton component repos (TRI-1877), triggered by upstream PyTorch's ATen.h now requiring C++20.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Resolves: TRI-1877

Upstream PyTorch raised ATen's minimum required C++ standard from 17
to 20 (pytorch/pytorch#178150), which broke the pytorch_backend build.
Align this repo's TRITON_MIN_CXX_STANDARD/CMAKE_CXX_STANDARD default
with that floor for consistency across the stack.

TRI-1877
@mc-nv mc-nv self-assigned this Sep 9, 2026
@mc-nv mc-nv added the build Build system or external dependencies (build: PRs) label Sep 9, 2026
This was referenced Sep 9, 2026
@mc-nv
mc-nv marked this pull request as ready for review September 10, 2026 15:28
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge as a focused build-default update aligned with the coordinated C++20 migration.

Summary

  • Applies C++20 to the native backend and Python stub targets.
  • Applies -std=c++20 to CUDA compilation when GPU support is enabled.
  • Preserves the existing cache variable so consumers can explicitly override the default.

Reviews (1) · Last reviewed commit: "build: Update C++ standard from c++17 to..."

@mattwittwer mattwittwer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mc-nv
mc-nv merged commit 26764b9 into main Sep 11, 2026
4 checks passed
@mc-nv
mc-nv deleted the mchornyi/TRI-1877/TRI-1855-std-20 branch September 11, 2026 03:15
mc-nv added a commit that referenced this pull request Sep 11, 2026
Upstream PyTorch raised ATen's minimum required C++ standard from 17
to 20 (pytorch/pytorch#178150), which broke the pytorch_backend build.
Align this repo's TRITON_MIN_CXX_STANDARD/CMAKE_CXX_STANDARD default
with that floor for consistency across the stack.

TRI-1877

(cherry picked from commit 26764b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or external dependencies (build: PRs)

Development

Successfully merging this pull request may close these issues.

2 participants