Repository navigation
Commit abfa01a
authored
fix: declare the storage permission the extension background worker needs (#26)
## Summary
Fix: background notifications never scheduled in v0.4.0.
Chrome reported `Failed to handle cancel-end: TypeError: Cannot read properties of undefined (reading 'session')` from `background.js`. The worker keeps the pending notification text in `chrome.storage.session`, which requires the `storage` permission; without it `chrome.storage` is undefined, so `schedule-end` and `cancel-end` both threw and no end-of-session alarm was ever set. The manifest now declares `storage` (no install warning). The worker's other APIs are covered: `alarms` and `notifications` are declared; `tabs.create/update`, `windows.update` and `runtime.getContexts` need no permission.
## Testing
- Lint, typecheck, unit tests and build pass.
- Built manifest lists `notifications`, `alarms`, `storage`.
- Not run here: a real Chrome with the unpacked extension (this machine's Chrome ignores command-line extension loading); the earlier stub tests only covered the page side, which is how this slipped through.1 parent e4fa91e commit abfa01a
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
0 commit comments