Ember Frontend Developer Challenge - #5
Open
brianmarete wants to merge 3 commits into
Open
brianmarete wants to merge 3 commits into
brianmarete wants to merge 3 commits into
Conversation
I added an action in the index controller that handles the setting of a pinned task. This action handles logic for pinning, unpinning and replacing a pinned task. This action is passed down to the single task component through the task list component and is triggered when the pin/unpin button is clicked. I also added an attribute to the task model and I use this to display or hide the task in the task list. There's probably a better way to do this though as I don't think this attribute belongs to the model.
I added a computed property in the index controller that finds all the tasks marked complete. These tasks are in an array so the computed property returns the length of the array.
I created a new component that handles the toggling of task completion. I then refactored the button for toggling "Done/Undo" from the single task component to the new component. I created an action in the single task component to handle the toggling of the 'isComplete' property on tasks. This action is what is passed down to the ToggleComplete component and is triggered by a click event on the "Done/Undo" button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my submission for the Ember Frontend Developer Challenge. The changes include: