Repository navigation
@tus/utils: fix FileKvStore list pairing - #892
Merged
Merged
Conversation
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
🦋 Changeset detectedLatest commit: f0874c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+38
to
+40
| const files = new Set(await fs.readdir(this.directory)) | ||
| // To only return tus file IDs we check if the file has a corresponding JSON info file | ||
| return sorted.filter( | ||
| (file, idx) => idx < sorted.length - 1 && name(file) === name(sorted[idx + 1]) | ||
| ) | ||
| return [...files].filter((file) => files.has(`${file}.json`)).sort() |
There was a problem hiding this comment.
🔍 Nested uploads remain outside expiration scans
For nested upload IDs, list() reads only the top-level directory. FileStore.create places these uploads in subdirectories, so FileStore.deleteExpired never sees them. This predates the pairing change.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Author
There was a problem hiding this comment.
correct but it's a different existing issue
Murderlon
approved these changes
Oct 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.