Repository navigation
@tus/utils: include nested uploads in FileKvStore listing - #894
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
🦋 Changeset detectedLatest commit: 42855e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
FileKvStore.list()to return nested upload IDs such asusers/alice/upload, soFileStore.deleteExpired()can find them. Built on merged #892, retaining exact same-directory file/metadata pairing and sorted IDs. Recursive enumeration excludes directories and symlinks.Adds regression coverage for nested paths, cross-directory pairing, symlink traversal, and expiration cleanup. Includes a patch changeset noting that cleanup now removes existing nested uploads that meet the expiration rules; no API or storage-format change.
Validation: build, formatting, and lint pass locally. Tests run in CI per repository guidance.
Link to Devin session: https://app.devin.ai/sessions/db3a7751409a4b669c7b2e955c0c0ec5
Open in Devin Desktop: https://app.devin.ai/desktop/session/db3a7751409a4b669c7b2e955c0c0ec5?variant=devin
Requested by: @Murderlon