Repository navigation
@tus/file-store: preserve completed uploads during expiration cleanup - #898
Merged
Merged
Conversation
ferhatelmas
had a problem deploying
to
external-testing
October 26, 2026 13:07 — with 
GitHub Actions
Error
GitHub Actions
Error
🦋 Changeset detectedLatest commit: eb50704 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
195
to
+197
| info.size !== info.offset && | ||
| info.creation_date | ||
| info.creation_date && | ||
| now > Date.parse(info.creation_date) + expiration |
There was a problem hiding this comment.
🔍 Completed uploads remain expired to protocol clients
Cleanup preserves completed files, but HeadHandler and PatchHandler still return 410 after their creation-based deadline. Clients cannot query those uploads through HEAD.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Author
ferhatelmas
force-pushed
the
file-expiration-cleanup
branch
from
October 26, 2026 20:10
fd91b0e to
7455c04
Compare
ferhatelmas
had a problem deploying
to
external-testing
October 26, 2026 20:10 — with
GitHub Actions
Error
GitHub Actions
Error
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
file-expiration-cleanup
branch
from
October 26, 2026 20:47
7455c04 to
eb50704
Compare
Murderlon
approved these changes
Oct 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #320 (introduced)
related to #894 (extended)
Currently, metadata offset is checked but it's never persisted. Cleanup could remove completed files. Compare the actual file size instead.
There is an inherent issue for uploads in progress because cleanup doesn't take the lock but it should be handled separately since requires a refactoring.