Skip to content

@tus/s3-store: keep cached metadata in sync on length declaration and removal - #901

Open
ferhatelmas wants to merge 1 commit into
tus:mainfrom
ferhatelmas:metadata-sync
Open

@tus/s3-store: keep cached metadata in sync on length declaration and removal#901
ferhatelmas wants to merge 1 commit into
tus:mainfrom
ferhatelmas:metadata-sync

Conversation

@ferhatelmas

@ferhatelmas ferhatelmas commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

related to #900

Devin Review

@ferhatelmas
@tus/s3-store: keep cached metadata in sync on length declaration and…
c49388f 
… removal

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
@changeset-bot

changeset-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c49388f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tus/s3-store Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Oct 26, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@ferhatelmas ferhatelmas mentioned this pull request Oct 26, 2026
Open
@devin-ai-integration

devin-ai-integration Bot commented Oct 28, 2026

Copy link
Copy Markdown

Could we also invalidate cached metadata in deleteExpired() here? That path bypasses remove(), so awaiting clearCache() there doesn’t cover expiration cleanup. A regression test that warms the cache, expires and deletes an incomplete upload, then verifies getUpload() reports it missing would cover this.

Separately, getUpload() still treats a missing multipart upload as completed when .info survives—for example after an S3 lifecycle abort. That can be a follow-up, but we should address it before #900 starts exempting these uploads from expiration.

This branch is waiting to be deployed

1 waiting deployment
external-testing — c49388fd Waiting Oct 26, 2026 by ferhatelmas via Tests #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ferhatelmas