Add behaviour-finding tests and update README to reflect findings

Author: tvandinther

Libsql.Client.Tests/ExecuteTests.cs

@@ -39,7 +39,7 @@ public async Task RowsAffected_ReturnsExpectedValue()
     [Fact]
     public async Task RowsAffected_ReturnsExectedValue_WhenMultipleUpdates()
     {
-        await _db.Query("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `value` INTEGER)");
+        await _db.Execute("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `value` INTEGER)");
 
         for (int i = 0; i < 10; i++)
         {
@@ -50,4 +50,15 @@ public async Task RowsAffected_ReturnsExectedValue_WhenMultipleUpdates()
 
         Assert.Equal(10ul, rs2.RowsAffected);
     }
+
+    [Fact]
+    public async Task Throws_WhenRowsReturned()
+    {
+        async Task action()
+        {
+            await _db.Execute("SELECT 1");
+        }
+
+        await Assert.ThrowsAsync<LibsqlException>(action);
+    }
 }

Libsql.Client.Tests/ResultSetTests.cs

@@ -43,6 +43,14 @@ public async Task Columns_NamesAreMarshalled_WhenSeveral()
         Assert.Equal("column_two", columns.Last());
     }
 
+    [Fact]
+    public async Task LastInsertRowId_Zero_WhenNonQuery()
+    {
+        var rs = await _db.Query("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT)");
+
+        Assert.Equal(0, rs.LastInsertRowId);
+    }
+
     [Fact]
     public async Task LastInsertRowId_ReturnsExpectedValue()
     {
@@ -66,6 +74,14 @@ public async Task LastInsertRowId_ReturnsExpectedValue_WhenMultipleInserts()
         }
     }
 
+    [Fact]
+    public async Task RowsAffected_Zero_WhenNonQuery()
+    {
+        var rs = await _db.Query("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT)");
+
+        Assert.Equal(0ul, rs.RowsAffected);
+    }
+
     [Fact]
     public async Task RowsAffected_ReturnsExpectedValue()
     {

Libsql.Client.Tests/RowsTests.cs

@@ -3,6 +3,48 @@
 public class RowsTests
 {
     private readonly IDatabaseClient _db = DatabaseClient.Create().Result;
+
+    [Fact]
+    public async Task IteratedRows_Throws_WhenCreate()
+    {
+        async Task<IEnumerable<IEnumerable<Value>>> Action() {
+            var rs = await _db.Query("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT)");
+
+            return rs.Rows.ToList();
+        }
+        
+        await Assert.ThrowsAsync<LibsqlException>(Action);
+    }
+
+    [Fact]
+    public async Task IteratedRows_Throws_WhenCreateIfNotExists()
+    {
+        var rs = await _db.Query("CREATE TABLE IF NOT EXISTS `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT)");
+        
+        Assert.Empty(rs.Rows);
+    }
+
+    [Fact]
+    public async Task Rows_Empty_WhenInsert()
+    {
+        await _db.Query("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT)");
+
+        var rs = await _db.Query("INSERT INTO `test` (`name`) VALUES ('libsql')");
+        
+        Assert.Empty(rs.Rows);
+    }
+
+    [Fact]
+    public async Task Rows_Empty_WhenUpdate()
+    {
+        await _db.Query("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT)");
+        var rs = await _db.Query("INSERT INTO `test` (`name`) VALUES ('libsql')");
+        Assert.Equal(1ul, rs.RowsAffected);
+
+        var rs2 = await _db.Query("UPDATE `test` SET `name` = 'libsql2' WHERE id = 1");
+        
+        Assert.Empty(rs2.Rows);
+    }
 
     [Fact]
     public async Task Rows_WhenEmpty()

Libsql.Client.Tests/StatementTests.cs

@@ -4,21 +4,6 @@ public class StatementTests
 {
     private readonly IDatabaseClient _db = DatabaseClient.Create().Result;
 
-    public StatementTests()
-    {
-        _db.Execute("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT)");
-        _db.Execute("INSERT INTO `test` VALUES ('a', 'b', 'c')");
-    }
-
-    [Fact]
-    public async Task Prepare_ReturnedStatement_CanBeExecuted()
-    {
-        using var statement = await _db.Prepare("SELECT `id` FROM `test` WHERE `name` = ?");
-
-        Assert.NotNull(statement);
-        Assert.IsAssignableFrom<IStatement>(statement);
-    }
-
     [Fact]
     public async Task Statement_CanBind_Integer()
     {
@@ -104,4 +89,42 @@ public async Task Statement_BoundValuesCount_IsCorrect()
 
         Assert.Equal(3, numberOfBoundValues);
     }
+
+    [Fact]
+    public async Task Database_CanQuery_Statements()
+    {
+        using var statement = await _db.Prepare("SELECT ?");
+        var expected = 1;
+
+        statement.Bind(new Integer(expected));
+        var rs = await _db.Query(statement);
+        var row = rs.Rows.First();
+        var value = row.First();
+        var integer = Assert.IsType<Integer>(value);
+
+        Assert.Equal<int>(expected, integer);
+    }
+
+    [Fact]
+    public async Task Statement_CanExecute()
+    {
+        await _db.Execute("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT)");
+        using var statement = await _db.Prepare("INSERT INTO `test` (`name`) VALUES ('a'), ('b'), ('c')");
+
+        var rowsAffected = await statement.Execute();
+
+        Assert.Equal(3ul, rowsAffected);
+    }
+    
+
+    [Fact]
+    public async Task Database_CanExecute_Statements()
+    {
+        await _db.Execute("CREATE TABLE `test` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` TEXT)");
+        using var statement = await _db.Prepare("INSERT INTO `test` (`name`) VALUES ('a'), ('b'), ('c')");
+
+        var rowsAffected = await _db.Execute(statement);
+
+        Assert.Equal(3ul, rowsAffected);
+    }
 }

README.md

@@ -57,7 +57,7 @@ await statement.Query(userId);
 
 #### `Execute` vs. `Query`
 
-`Execute` returns only the number of affected rows and is intended for statements where further detail is not necessary.
+`Execute` returns only the number of affected rows and is intended for statements where further detail is not necessary. A `LibSqlException` will be thrown if you use `Execute` on a statement that returns rows.
 
 `Query` returns a more useful `IResultSet` object which can be read for additional information such as the number of affected rows, the last inserted row ID, the column names, and the rows themselves.