fix(call-recorder): make the recording switch cancel asynchronously and gate every bot creation

Addresses the review on the switch.

The sync route no longer walks open recordings one at a time calling
Recall inline, which risked the 900s timeout and hammered a rate-limited
API from a request the settings toggle waits on. It now flips every open
request to canceled in bulk, reusing the batched update the uninstall
hook already uses, and enqueues cancel-scheduled-recall-bots for the
slow part. That job deletes bots with bounded concurrency, works in
bounded slices, and re-enqueues itself only when a run actually freed a
bot, so a Recall outage stops the chain instead of spinning. The daily
cancellation retry stays the backstop it already was, so no new cron is
needed.

The policy gate only covered reconciliation, so a request whose
cancellation failed could still be picked up by the pending-request
recovery cron and given a bot with the switch off. The check now sits in
scheduleRecallBotForCallRecording, the single place a bot is created,
which closes every recovery path at once.

On the front end a failed save reverted nothing, so the tab would hide
every setting and claim recording was paused while it was still running;
the switch now rolls back on failure. The save queue also awaits the
sync, so toggling off and straight back on can no longer run two syncs
concurrently. Docs now use the switch's real label.

Author: ehconitin

packages/twenty-apps/public/call-recorder/README.md

@@ -24,7 +24,7 @@ variable to `false` to turn summaries off.
 
 ## 🗓️ Pausing the recorder
 
-The **Send bot to all my calendar meetings** toggle in the app settings is on
+The **Record my calendar meetings** toggle in the app settings is on
 by default. Turn it off to stop scheduling bots for upcoming meetings and cancel
 every recording that is already scheduled. Turn it back on and the app sweeps
 upcoming meetings to schedule bots again.

packages/twenty-apps/public/call-recorder/SETUP.md

@@ -36,7 +36,7 @@ Set these on the application registration after installing
 | `RECALL_WEBHOOK_SECRET` | Yes | Svix signing secret (`whsec_…`) used to verify incoming Recall webhooks. |
 
 > **Calendar scheduling** (`CALL_RECORDER_CALENDAR_BOT_SCHEDULING_ENABLED`,
-> the "Send bot to all my calendar meetings" toggle; turning it off cancels
+> the "Record my calendar meetings" toggle; turning it off cancels
 > every scheduled recording), **bot behavior settings** (display name,
 > recording notice, join timing, lobby and leave timeouts), the transcription
 > provider

packages/twenty-apps/public/call-recorder/src/__tests__/call-recorder-lifecycle.integration-test.ts

@@ -16,6 +16,7 @@ import { reconcileCallRecorderForCalendarEventIds } from 'src/logic-functions/fl
 import { retryFailedRecallCancellations } from 'src/logic-functions/flows/retry-failed-recall-cancellations.util';
 import { scheduleRecallBotsForPendingCallRecordings } from 'src/logic-functions/flows/schedule-recall-bots-for-pending-call-recordings.util';
 import { processRecallWebhookHandler } from 'src/logic-functions/process-recall-webhook';
+import { cancelScheduledRecallBotsHandler } from 'src/logic-functions/cancel-scheduled-recall-bots';
 import { syncCalendarBotSchedulingHandler } from 'src/logic-functions/sync-calendar-bot-scheduling';
 import { CALL_RECORDER_CALENDAR_BOT_SCHEDULING_ENABLED_ENV_VAR_NAME } from 'src/logic-functions/constants/call-recorder-calendar-bot-scheduling-enabled-env-var-name';
 
@@ -924,25 +925,45 @@ describe('call recorder app lifecycle (integration)', () => {
         'false',
       );
 
-    it('cancels every scheduled recording and its bot when turned off', async () => {
+    it('cancels the request inline and leaves the Recall bot to the enqueued job', async () => {
       const { callRecordingId, botId } =
         await scheduleRecordingThroughCalendarReconciliation();
 
       turnRecordingOff();
 
       const result = await syncCalendarBotSchedulingHandler();
+
+      expect(result).toEqual(
+        expect.objectContaining({ outcome: 'scheduled-bots-canceled' }),
+      );
+      expect(
+        (await fetchCallRecording(callRecordingId)).recordingRequestStatus,
+      ).toBe('CANCELED');
+      // The toggle must not wait on Recall, so the bot is still alive here.
+      expect(recall.deletedBotIds).not.toContain(botId);
+
+      await cancelScheduledRecallBotsHandler();
+
       const callRecording = await fetchCallRecording(callRecordingId);
 
-      expect(callRecording.recordingRequestStatus).toBe('CANCELED');
       expect(callRecording.externalBotId).toBeFalsy();
       expect(recall.deletedBotIds).toContain(botId);
-      expect(result).toEqual(
-        expect.objectContaining({
-          outcome: 'scheduled-bots-canceled',
-          canceledCallRecordingIds: expect.arrayContaining([callRecordingId]),
-          failedCallRecordingIds: [],
-        }),
-      );
+    });
+
+    it('does not schedule a bot for a request the cancellation missed', async () => {
+      const calendarEventId = await createCalendarEvent();
+      const callRecordingId = await createPendingCallRecording({
+        calendarEventId,
+      });
+
+      turnRecordingOff();
+
+      await runPendingRecoveryCron();
+
+      const callRecording = await fetchCallRecording(callRecordingId);
+
+      expect(callRecording.externalBotId).toBeFalsy();
+      expect(recall.botForCallRecording(callRecordingId)).toBeUndefined();
     });
 
     it('schedules nothing for an upcoming meeting while turned off', async () => {

packages/twenty-apps/public/call-recorder/src/constants/universal-identifiers.ts

@@ -70,6 +70,9 @@ export const CALL_RECORDING_TRANSCRIPT_IMPORT_CLAIMED_AT_FIELD_UNIVERSAL_IDENTIF
 export const CALL_RECORDING_VIDEO_FIELD_UNIVERSAL_IDENTIFIER =
   'bb9523d3-457e-4f4b-8c79-27a77afb87da';
 
+export const CANCEL_SCHEDULED_RECALL_BOTS_LOGIC_FUNCTION_UNIVERSAL_IDENTIFIER =
+  'a1b0f097-edeb-45a3-a53e-bf666cbfe3a4';
+
 export const CANCEL_RECALL_BOT_ON_CALL_RECORDING_DELETE_LOGIC_FUNCTION_UNIVERSAL_IDENTIFIER =
   '84981386-881f-4123-a2dd-82e0932ba663';
 

packages/twenty-apps/public/call-recorder/src/front-components/components/SchedulingSection.tsx

@@ -21,6 +21,9 @@ export const SchedulingSection = ({
     frontComponentId,
     variableKey: CALL_RECORDER_CALENDAR_BOT_SCHEDULING_ROW.variableKey,
     onSaveSuccess: () => requestCalendarBotSchedulingSync(),
+    // A failed save would otherwise leave the tab hiding every setting while
+    // the recorder is in fact still running.
+    onSaveError: (value) => onEnabledChange(value !== 'true'),
   });
 
   const handleChange = (checked: boolean) => {

packages/twenty-apps/public/call-recorder/src/front-components/components/Toggle.tsx

@@ -20,10 +20,8 @@ const TOGGLE_DIMENSIONS_BY_SIZE: Record<ToggleSize, ToggleDimensions> = {
 
 const THUMB_INSET_PIXELS = 2;
 
-const getCheckedThumbOffsetPixels = ({
-  width,
-  thumbSize,
-}: ToggleDimensions) => width - thumbSize - THUMB_INSET_PIXELS;
+const getCheckedThumbOffsetPixels = ({ width, thumbSize }: ToggleDimensions) =>
+  width - thumbSize - THUMB_INSET_PIXELS;
 
 const StyledToggle = styled.button<{
   $toggleSize: ToggleSize;
@@ -37,7 +35,8 @@ const StyledToggle = styled.button<{
   cursor: pointer;
   display: flex;
   flex-shrink: 0;
-  height: ${({ $toggleSize }) => TOGGLE_DIMENSIONS_BY_SIZE[$toggleSize].height}px;
+  height: ${({ $toggleSize }) =>
+    TOGGLE_DIMENSIONS_BY_SIZE[$toggleSize].height}px;
   padding: 0;
   position: relative;
   transition: background-color
@@ -75,9 +74,7 @@ const StyledThumb = styled.span<{
   &[data-checked='true'] {
     transform: translate(
       ${({ $toggleSize }) =>
-        getCheckedThumbOffsetPixels(
-          TOGGLE_DIMENSIONS_BY_SIZE[$toggleSize],
-        )}px,
+        getCheckedThumbOffsetPixels(TOGGLE_DIMENSIONS_BY_SIZE[$toggleSize])}px,
       -50%
     );
   }

packages/twenty-apps/public/call-recorder/src/front-components/hooks/use-autosave-application-variable.ts

@@ -9,22 +9,26 @@ import { createApplicationVariableSaveQueue } from 'src/front-components/utils/c
 type UseAutosaveApplicationVariableParams = {
   frontComponentId: string;
   variableKey: string;
-  onSaveSuccess?: (value: string) => void;
+  onSaveSuccess?: (value: string) => void | Promise<void>;
+  onSaveError?: (value: string) => void;
 };
 
 export const useAutosaveApplicationVariable = ({
   frontComponentId,
   variableKey,
   onSaveSuccess,
+  onSaveError,
 }: UseAutosaveApplicationVariableParams) => {
   const { saveApplicationVariable } =
     useSaveApplicationVariable(frontComponentId);
   const saveApplicationVariableRef = useRef(saveApplicationVariable);
   const onSaveSuccessRef = useRef(onSaveSuccess);
+  const onSaveErrorRef = useRef(onSaveError);
   const variableKeyRef = useRef(variableKey);
 
   saveApplicationVariableRef.current = saveApplicationVariable;
   onSaveSuccessRef.current = onSaveSuccess;
+  onSaveErrorRef.current = onSaveError;
   variableKeyRef.current = variableKey;
 
   const saveQueueRef = useRef<
@@ -40,8 +44,14 @@ export const useAutosaveApplicationVariable = ({
         });
 
         if (isSaved) {
-          onSaveSuccessRef.current?.(value);
+          // Awaited so the queue serializes the follow-up work of consecutive
+          // saves; two toggles in a row must not sync concurrently.
+          await onSaveSuccessRef.current?.(value);
+
+          return;
         }
+
+        onSaveErrorRef.current?.(value);
       },
     });
   }

packages/twenty-apps/public/call-recorder/src/front-components/utils/get-normalized-number-value.util.ts

@@ -1,8 +1,6 @@
 // Returns undefined when the draft cannot be stored, so a half-typed number is
 // kept on screen instead of being persisted as a broken value.
-export const getNormalizedNumberValue = (
-  value: string,
-): string | undefined => {
+export const getNormalizedNumberValue = (value: string): string | undefined => {
   const trimmedValue = value.trim();
 
   if (trimmedValue === '') {

packages/twenty-apps/public/call-recorder/src/front-components/utils/request-calendar-bot-scheduling-sync.util.ts

@@ -5,8 +5,7 @@ import { SYNC_CALENDAR_BOT_SCHEDULING_ROUTE_PATH } from 'src/constants/sync-cale
 
 type SyncCalendarBotSchedulingResponse = {
   outcome?: string;
-  canceledCallRecordingIds?: string[];
-  failedCallRecordingIds?: string[];
+  canceledCallRecordingCount?: number;
 };
 
 const buildSnackbarForResponse = (
@@ -16,15 +15,7 @@ const buildSnackbarForResponse = (
     return undefined;
   }
 
-  const canceledCount = (response.canceledCallRecordingIds ?? []).length;
-  const failedCount = (response.failedCallRecordingIds ?? []).length;
-
-  if (failedCount > 0) {
-    return {
-      message: `Could not cancel ${failedCount} scheduled recording${failedCount === 1 ? '' : 's'}.`,
-      variant: 'error',
-    };
-  }
+  const canceledCount = response.canceledCallRecordingCount ?? 0;
 
   if (canceledCount === 0) {
     return undefined;

packages/twenty-apps/public/call-recorder/src/logic-functions/__tests__/schedule-recall-bot-on-call-recording-update.test.ts

@@ -36,7 +36,9 @@ type HandlerEvent = Parameters<
   typeof scheduleRecallBotOnCallRecordingUpdateHandler
 >[0];
 
-const buildUpdateEvent = (overrides: Partial<HandlerEvent> = {}): HandlerEvent =>
+const buildUpdateEvent = (
+  overrides: Partial<HandlerEvent> = {},
+): HandlerEvent =>
   ({
     name: 'callRecording.updated',
     recordId: 'call-recording-1',
@@ -150,9 +152,8 @@ describe('scheduleRecallBotOnCallRecordingUpdateHandler', () => {
   it('schedules a bot when an update clears the bot id of a requested recording', async () => {
     stubPendingCallRecordingQueries();
 
-    const result = await scheduleRecallBotOnCallRecordingUpdateHandler(
-      buildUpdateEvent(),
-    );
+    const result =
+      await scheduleRecallBotOnCallRecordingUpdateHandler(buildUpdateEvent());
 
     expect(result).toEqual({
       callRecordingId: 'call-recording-1',
@@ -256,9 +257,8 @@ describe('scheduleRecallBotOnCallRecordingUpdateHandler', () => {
       ]),
     }));
 
-    const result = await scheduleRecallBotOnCallRecordingUpdateHandler(
-      buildUpdateEvent(),
-    );
+    const result =
+      await scheduleRecallBotOnCallRecordingUpdateHandler(buildUpdateEvent());
 
     expect(result).toEqual({
       callRecordingId: 'call-recording-1',
@@ -313,9 +313,8 @@ describe('scheduleRecallBotOnCallRecordingUpdateHandler', () => {
       ]),
     }));
 
-    const result = await scheduleRecallBotOnCallRecordingUpdateHandler(
-      buildUpdateEvent(),
-    );
+    const result =
+      await scheduleRecallBotOnCallRecordingUpdateHandler(buildUpdateEvent());
 
     expect(result).toEqual({
       callRecordingId: 'call-recording-1',