Remove the "Answered in" duration footer from Slack assistant replies - #25237
Conversation
|
👋 Thanks for contributing to Twenty! Your PR has been set to draft while you work on it. Once you're done, mark it as Ready for review and our automated checks will run. Looking forward to your contribution! |
Greptile SummaryRemoves elapsed-time footers from Slack assistant replies while retaining backward-compatible stripping of footers in historical thread messages.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The footer removal is consistently applied across rich and fallback replies, feedback metadata remains intact, legacy thread cleanup is preserved, and no stale references to the deleted utilities remain. Important Files Changed
Reviews (1): Last reviewed commit: "Remove the "Answered in" duration footer..." | Re-trigger Greptile |
d4c5fd6 to
d23d8a2
Compare
🤖 PR Review
🛡️ Security Review✅ No high-severity vulnerabilities detected. 🚦 Auto-approve✅ Eligible for auto-approval — low-complexity, no high-blast-radius paths.
Automated pre-review — human approval still required. |
✅ Quality review · no findings
High-level — Clean single-purpose removal of the Slack answer-duration footer; correctly keeps and re-justifies the still-used strip util for backward-compatible history replay, no rollout or data risk Reviewed against the |
CoreTeamTwenty
left a comment
There was a problem hiding this comment.
✅ Auto-approved — cleared automated quality and security review and is low-complexity.
- Quality: passed
- Security: passed
- Auto-approve: passed — complexity low
Automated approval — a human still merges, and this is re-evaluated on every push.
Superseded — re-approving the latest commit.
CoreTeamTwenty
left a comment
There was a problem hiding this comment.
✅ Auto-approved — cleared automated quality and security review and is low-complexity.
- Quality: passed
- Security: passed
- Auto-approve: passed — complexity low
Automated approval — a human still merges, and this is re-evaluated on every push.
LogDetails |
Removes the "Answered in {x}s" footer the Slack assistant appended to every answer.
What changed
build-slack-assistant-answer-blocks.ts: dropped the "Answered in {x}s" context block, so rich replies are now the markdown body plus the feedback buttons.responseTextdirectly.build-slack-assistant-answer-text.ts, which only existed to append the footer, is deleted along with its test.format-slack-assistant-duration.tsdeleted (no remaining users); the worker no longer tracksstartedAt/durationMilliseconds.strip-slack-assistant-answer-footer.tsis deliberately kept: it strips the footer from the bot's own earlier messages when replaying thread history into the agent context, and still-live threads contain footered messages posted by previous versions. Its comment now explains that.Validation
yarn typecheckcleanyarn lint0 warnings / 0 errorsyarn test:unit193 tests pass (2 fewer than before: the deleted footer tests)Generated by Claude Code