Skip to content

Commit a8f860f

Browse files
authored
Merge pull request #223 from KubaO/staging
Help add-in hover help and a detachable help window, exe-run reporting in the harness, and 997 reproducibility bugs
2 parents e820a16 + c589d51 commit a8f860f

370 files changed

Lines changed: 10070 additions & 3132 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/checks.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,11 @@ jobs:
9797
# broken link still produces a site worth inspecting -- so the
9898
# step fails on the exit code: 1 when the check found a problem,
9999
# 2 when the build could not run.
100-
run: node builder/tbdocs.mjs --src docs --no-fetch-assets --check-audit-index
100+
#
101+
# --no-help-archive: a local build ends by zipping the offline tree
102+
# for the IDE help add-in. CI has no use for that archive and must
103+
# not spend time on it.
104+
run: node builder/tbdocs.mjs --src docs --no-fetch-assets --no-help-archive --check-audit-index
101105
# The gates both workflows run, in one list: see
102106
# .github/actions/run-gates/action.yml, which check_ci_workflows.mjs
103107
# checks against test.bat and check.bat. Each gate is its own group in

‎.github/workflows/tbdocs-gh-pages.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,11 @@ jobs:
9292
# baseurl off the config it just built with. Only the
9393
# online tree gets a base path -- the offline tree's links are all
9494
# relative after the rewrite.
95-
run: node builder/tbdocs.mjs --src docs --url '${{ steps.pages.outputs.origin }}' --baseurl '${{ steps.pages.outputs.base_path }}' --no-fetch-assets --check-audit-index
95+
#
96+
# --no-help-archive: a local build ends by zipping the offline tree
97+
# for the IDE help add-in. CI has no use for that archive and must
98+
# not spend time on it.
99+
run: node builder/tbdocs.mjs --src docs --url '${{ steps.pages.outputs.origin }}' --baseurl '${{ steps.pages.outputs.base_path }}' --no-fetch-assets --no-help-archive --check-audit-index
96100
# The gates both workflows run, in one list: see
97101
# .github/actions/run-gates/action.yml, which check_ci_workflows.mjs
98102
# checks against test.bat and check.bat. checks.yml runs only on pull

‎.gitignore‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,9 @@ indexer/.packages/
2828
# docs/assets/fonts/ -- only the archives are throwaway.
2929
/.font-cache/
3030

31-
# The help add-in's documentation archive is built by scripts/build_help_archive.mjs
32-
# from docs/_site-offline, and is too large to commit.
31+
# The help add-in's documentation archive is written by a local build of the
32+
# documentation (builder/help-archive-step.mjs) from docs/_site-offline, and is
33+
# too large to commit.
3334
/add-in/Resources/HELP/
3435

3536
# A bug reproducer's zip is only for attaching to its GitHub issue (see

‎BUGS-TO-REPORT.md‎

Lines changed: 90 additions & 1413 deletions
Large diffs are not rendered by default.

‎WIP.ExamplesBuild.md‎

Lines changed: 46 additions & 49 deletions
Large diffs are not rendered by default.

‎WIP.Harness.md‎

Lines changed: 49 additions & 41 deletions
Large diffs are not rendered by default.

‎WIP.HelpAddin.md‎

Lines changed: 201 additions & 28 deletions
Large diffs are not rendered by default.

‎WIP.Search.md‎

Lines changed: 662 additions & 784 deletions
Large diffs are not rendered by default.

‎WIP.Typography.md‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,12 @@ prefer that shape where the layout allows it.
2727
**A footnote back-link shows the hazard.** It is a bare inline `<a>` holding a
2828
single U+21A9 with no padding, so its target is whatever box the font gives that
2929
glyph: 12.09 x 19 on Segoe UI, 12.09 x 15 on Liberation Sans, 15.97 x 17 on
30-
Inter. **None of those meets 24 x 24.** It passed on axe's *spacing* exception
31-
--- a 24px circle centred on the target clears its neighbours --- until Inter's
32-
arrow, 3.9px wider, moved the centre far enough to intersect one. The fix sizes
33-
the link outright (`display: inline-block; min-width/min-height: 24px`) rather
34-
than restoring the clearance.
30+
Inter. **None of those meets 24 x 24.** It can pass on axe's *spacing* exception
31+
--- a 24px circle centred on the target clears its neighbours --- and a wider
32+
glyph fails it: Inter's arrow is 3.9px wider than Segoe UI's, enough to move the
33+
centre far enough to intersect a neighbour. The link is sized outright
34+
(`display: inline-block; min-width/min-height: 24px`) rather than relying on the
35+
clearance.
3536

3637
Two rules follow. **Run the full sweep after any change that moves type
3738
metrics**: the thirteen-page sample stays clean through such a change and would

‎WIP.md‎

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)