Repository navigation
Conversation
…is active
The no-query branch returned the literal JSX text "props.text" instead of
the prop's value, since {props.text} was written as plain text instead of
an expression. Add a direct regression test for both the no-query and
active-query render paths.
zigzagdev
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
October 20, 2026 00:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HighlightCellText's no query branch was returning the literal JSX text "props.text" instead of the actual prop value, because{props.text}had been written as plain text rather than an expression.Through the component's only two current callers (
StringColumnandCategoricalColumn) this branch is guarded by a truthy check on the same query value before the component is ever invoked, so today it behaves as dead code rather than a live regression.Still, the implementation itself is unambiguously wrong, and anyone exercising this component directly, through a future caller that doesn't add that guard, or through a direct unit test, would see the broken output.
Fixing it now closes that gap before it can surface as a real bug.
Description
Changed the no query branch in
src/data-table/text-search.tsxto render {props.text} instead of the literal string props.text.Added a direct regression test for
HighlightCellTextcovering both the no query and active query render paths, since the existingtest-search.test.tsfile only exercised thesplitByQueryhelper and never rendered this component directly.Scope
Patch (Bug Fix)