Skip to content

Commit 3571fbd

Browse files
authored
Merge pull request #136 from mingfeng-ucloud/feature/udns
fix ttl unset at record modify
2 parents 07ce20a + 7d8ed55 commit 3571fbd

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎products/udns/internal/udns/record_modify.go‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@ import (
1212
)
1313

1414
func newRecordModifyCommand(ctx *cli.Context) *cobra.Command {
15+
var ttl int
1516
client := cli.NewServiceClient(ctx, udnssdk.NewClient)
1617
req := client.NewModifyUDNSRecordRequest()
1718
cmd := &cobra.Command{
1819
Use: "modify",
1920
Short: "Modify a DNS record in a UDNS zone",
2021
Long: "Modify a DNS record in a UDNS zone",
2122
Run: func(cmd *cobra.Command, args []string) {
23+
if cmd.Flags().Changed("ttl") {
24+
req.TTL = &ttl
25+
}
2226
recordID := ctx.PickResourceID(*req.RecordId)
2327
req.RecordId = &recordID
2428
_, err := client.ModifyUDNSRecord(req)
@@ -37,7 +41,8 @@ func newRecordModifyCommand(ctx *cli.Context) *cobra.Command {
3741
req.Type = flags.String("type", "", "Optional. Record type: A, AAAA, CNAME, MX, TXT, SRV, PTR")
3842
req.Value = flags.String("value", "", `Optional. Value string: "IP|weight|enabled,..."`)
3943
req.ValueType = flags.String("value-type", "", "Optional. Normal or Multivalue")
40-
req.TTL = flags.Int("ttl", 0, "Optional. TTL in seconds (5-600); 0 means unchanged")
44+
//req.TTL = flags.Int("ttl", 0, "Optional. TTL in seconds (5-600); 0 means unchanged")
45+
flags.IntVar(&ttl, "ttl", 0, "Optional. TTL in seconds (5-600); 0 means unchanged")
4146
req.Remark = flags.String("remark", "", "Optional. Remark")
4247
ctx.BindRegion(cmd, req)
4348
ctx.BindProjectID(cmd, req)

0 commit comments

Comments
 (0)