Disable delete for in-use licenses, add tooltip (#137)

* Disable delete for in-use licenses, add tooltip

Prevent deleting licenses that are attached to bitstreams by disabling the Delete button and showing a tooltip explaining why. Adds UI markup (ngbTooltip wrapper, aria-label, dsBtnDisabled and guarded click), a new isSelectedLicenseInUse() helper and a check in deleteLicense(). Adds unit tests covering disabled/enabled states and click behavior, and provides i18n strings for English and Czech for the disabled-tooltip.

* Use hasNoValue for license id check

Replace isNull with hasNoValue when validating selectedLicense.id in deleteLicense to correctly handle undefined/null values. Also add hasNoValue to the imports from shared/empty.util.

* Use NgbTooltip instance in delete button spec

Update clarin-license-table component spec to import NgbTooltip and retrieve the tooltip instance from the delete wrapper's injector. Replace the previous assertion that inspected the DOM's ng-reflect-ngb-tooltip attribute with an assertion on deleteTooltip.ngbTooltip to verify the expected translation key. This makes the test more robust by avoiding reliance on Angular's rendered reflection attribute.

(cherry picked from commit 42c4fcc)

Author: amadulhaxxani

src/app/clarin-licenses/clarin-license-table/clarin-license-table.component.html

@@ -76,9 +76,21 @@
           </button>
         </div>
         <div class="btn-group pr-1">
-          <button type="button" class="btn btn-danger" [disabled]="selectedLicense == null" (click)="deleteLicense()">
-            {{'clarin-license.button.delete-license' | translate}}
-          </button>
+          <span
+            [ngbTooltip]="isSelectedLicenseInUse() ? ('clarin-license.button.delete-license.disabled-tooltip' | translate:{name: selectedLicense?.name}) : null"
+            container="body"
+            placement="top"
+            [attr.tabindex]="isSelectedLicenseInUse() ? 0 : null">
+            <button
+              type="button"
+              class="btn btn-danger"
+              [dsBtnDisabled]="selectedLicense == null || isSelectedLicenseInUse()"
+              (click)="selectedLicense != null && !isSelectedLicenseInUse() && deleteLicense()"
+              [attr.aria-label]="'clarin-license.button.delete-license' | translate">
+              <i class="fas fa-trash" aria-hidden="true"></i>
+              {{ 'clarin-license.button.delete-license' | translate }}
+            </button>
+          </span>
         </div>
       </div>
     </div>

src/app/clarin-licenses/clarin-license-table/clarin-license-table.component.spec.ts

@@ -16,8 +16,7 @@ import { PaginationServiceStub } from '../../shared/testing/pagination-service.s
 import { NotificationsService } from '../../shared/notifications/notifications.service';
 import { defaultPagination } from '../clarin-license-table-pagination';
 import { ClarinLicenseLabelDataService } from '../../core/data/clarin/clarin-license-label-data.service';
-import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
-import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
+import { NgbActiveModal, NgbModal, NgbTooltip } from '@ng-bootstrap/ng-bootstrap';
 import { HostWindowService } from '../../shared/host-window.service';
 import { HostWindowServiceStub } from '../../shared/testing/host-window-service.stub';
 import {
@@ -67,6 +66,7 @@ describe('ClarinLicenseTableComponent', () => {
       findAll: mockLicenseRD$,
       create: createdLicenseRD$,
       put: createdLicenseRD$,
+      delete: createNoContentRemoteDataObject$(),
       searchBy: mockLicenseRD$,
       getLinkPath: observableOf('')
     });
@@ -222,6 +222,55 @@ describe('ClarinLicenseTableComponent', () => {
     expect((component as ClarinLicenseTableComponent).licensesRD$).not.toBeNull();
   });
 
+  describe('license delete button', () => {
+    const getDeleteControls = () => {
+      const actionsRow = fixture.debugElement.query(By.css('.mt-2'));
+      const deleteWrapper = actionsRow.query(By.css('.btn-group.pr-1:last-child span'));
+      const deleteButton = deleteWrapper.query(By.css('button.btn-danger'));
+      return { deleteWrapper, deleteButton };
+    };
+
+    beforeEach(() => {
+      (clarinLicenseDataService.delete as jasmine.Spy).calls.reset();
+    });
+
+    it('should disable delete button and expose tooltip when selected license has bitstreams', () => {
+      component.selectedLicense = Object.assign({}, mockLicense, { bitstreams: 2 });
+      fixture.detectChanges();
+
+      const { deleteWrapper, deleteButton } = getDeleteControls();
+      const deleteTooltip = deleteWrapper.injector.get(NgbTooltip);
+
+      expect(deleteButton.attributes['aria-disabled']).toBe('true');
+      expect(deleteButton.nativeElement.classList.contains('disabled')).toBeTrue();
+      expect((deleteWrapper.nativeElement as HTMLElement).getAttribute('tabindex')).toBe('0');
+      expect(deleteTooltip.ngbTooltip as string).toContain('clarin-license.button.delete-l');
+    });
+
+    it('should not call delete when clicking disabled delete button', () => {
+      component.selectedLicense = Object.assign({}, mockLicense, { bitstreams: 1 });
+      fixture.detectChanges();
+
+      const { deleteButton } = getDeleteControls();
+      deleteButton.nativeElement.click();
+
+      expect((clarinLicenseDataService.delete as jasmine.Spy)).not.toHaveBeenCalled();
+    });
+
+    it('should enable delete button and call delete when selected license has no bitstreams', () => {
+      component.selectedLicense = Object.assign({}, mockLicense, { bitstreams: 0 });
+      fixture.detectChanges();
+
+      const { deleteWrapper, deleteButton } = getDeleteControls();
+      deleteButton.nativeElement.click();
+
+      expect(deleteButton.attributes['aria-disabled']).toBe('false');
+      expect(deleteButton.nativeElement.classList.contains('disabled')).toBeFalse();
+      expect((deleteWrapper.nativeElement as HTMLElement).getAttribute('tabindex')).toBeNull();
+      expect((clarinLicenseDataService.delete as jasmine.Spy)).toHaveBeenCalledWith(String(mockLicense.id));
+    });
+  });
+
   describe('label edit flow', () => {
     beforeEach(() => {
       notificationService.success.calls.reset();

src/app/clarin-licenses/clarin-license-table/clarin-license-table.component.ts

@@ -15,7 +15,7 @@ import { DefineLicenseLabelFormComponent } from './modal/define-license-label-fo
 import { ClarinLicenseConfirmationSerializer } from '../../core/shared/clarin/clarin-license-confirmation-serializer';
 import { NotificationsService } from '../../shared/notifications/notifications.service';
 import { TranslateService } from '@ngx-translate/core';
-import { isNull } from '../../shared/empty.util';
+import { hasNoValue, isNull } from '../../shared/empty.util';
 import { ClarinLicenseLabel } from '../../core/shared/clarin/clarin-license-label.model';
 import { ClarinLicenseLabelDataService } from '../../core/data/clarin/clarin-license-label-data.service';
 import { ClarinLicenseLabelExtendedSerializer } from '../../core/shared/clarin/clarin-license-label-extended-serializer';
@@ -356,7 +356,7 @@ export class ClarinLicenseTableComponent implements OnInit, OnDestroy {
    * Delete selected license. If none license is selected do nothing.
    */
   deleteLicense() {
-    if (isNull(this.selectedLicense?.id)) {
+    if (hasNoValue(this.selectedLicense?.id) || this.isSelectedLicenseInUse()) {
       return;
     }
     this.clarinLicenseService.delete(String(this.selectedLicense.id))
@@ -369,6 +369,13 @@ export class ClarinLicenseTableComponent implements OnInit, OnDestroy {
       });
   }
 
+  /**
+   * Returns whether selected license has attached bitstreams.
+   */
+  isSelectedLicenseInUse(): boolean {
+    return this.selectedLicense?.bitstreams > 0;
+  }
+
   /**
    * Open the edit modal for the selected license label, pre-filling its current values.
    * On confirm, calls the PUT service and refreshes the label list.

src/assets/i18n/cs.json5

@@ -9423,6 +9423,9 @@
   // "clarin-license.button.delete-license": "Delete License",
   "clarin-license.button.delete-license": "Odstranit licenci",
 
+  // "clarin-license.button.delete-license.disabled-tooltip": "License \"{{name}}\" cannot be deleted because it is attached to one or more bitstreams.",
+  "clarin-license.button.delete-license.disabled-tooltip": "Licenci \"{{name}}\" nelze smazat, protože jsou k ní připojeny jeden nebo více bitstreamů.",
+
   // "clarin-license.button.search": "Search",
   "clarin-license.button.search": "Hledat",
 

src/assets/i18n/en.json5

@@ -6245,6 +6245,8 @@
 
   "clarin-license.button.delete-license": "Delete License",
 
+  "clarin-license.button.delete-license.disabled-tooltip": "License \"{{name}}\" cannot be deleted because it is attached to one or more bitstreams.",
+
   "clarin-license.button.search": "Search",
 
   "clarin-license.button.search.placeholder": "Search by the license name ...",