Special characters trailing issue

[jcubic]

It seems that the PR to fix the slash as a trailing character of the URL didn't fix the issue:

• Trailing slash is not recognized as part of the link #756

I have a URL that ends with parenthesis:

https://en.wikipedia.org/wiki/Tree-sitter_(parser_generator)

And the closing parenthesis is not recognized as part of the URL.

The fix is to add all special characters or refactor the whole RegEx.

Potential fix using existing solution:

\b(?:[\/()[\].,;:!?']+)?

Also note that in hash you can put anything. I use a JSON array to keep the state in one of my websites.

https://terminal.jcubic.pl/404#[[0,1,"jargon%20magic"]]

Maybe it's worth using AI to create a full regex. Or use a library that is proven to work. It's also worth adding some tests to verify that the regex works correctly.

As for hash, I would just accept every non-space. Another option is to expose the regex to the user in the option (with the current default value) so the user can change it.

I can help create a PR if you're ok if it will be written by AI (of course, tested).

[jaywcjlove]

@jcubic Welcome to submit a PR! Thanks for your feedback and suggestions.

react-codemirror/extensions/hyper-link/src/index.ts

Line 13 in d10a51f

const defaultRegexp = /\b((?:https?|ftp):\/\/[^\s/$.?#].[^\s]*\b(?:\/)?)/gi;

[jcubic]

Which change should I make? Expose the regex, or try to fix it to handle my cases?

I can do both. The list of characters was given to me by Grok. He said that those are valid characters in a URL. As for the hash, when you copy from the address bar, the double quote is escaped, so they are not valid for URLs, but they can appear in the URL when in text.

What I would do is to add this regex:

\b(?:[\/()[\].,;:!?']+)?

And expose the regex as an option.