Add possibility for malloc to fail (via setting) - #798
Open
schuessf wants to merge 9 commits into
Open
Conversation
schuessf
requested review from
Heizmann,
bahnwaerter,
danieldietsch and
maul-esel
August 14, 2026 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, our C translation assumed that
malloc(and the other allocation functions,callocandrealloc) could never fail and returnNULL. For SV-COMP, it was decided that this assumption should be dropped (see !1686 for the corresponding benchmark changes and discussion). Therefore, this PR includes the following changes:Assume that allocation on the heap always succeedswas added. When disabled (the new default), allocation may returnNULLin our translation, otherwise the behavior remains unchanged.malloc, the procedure contract was changed (seeNonDetStrategy2DandSimpleIncreasingStrategy), while forcallocandreallocthe body in the translation was changed (seeStdlibLibraryModelandConstructRealloc).malloccalls internally, for "non-standard" purposes, that still rely on the allocation never failing: varargs handling (seeFunctionHandler) and non-deterministic string generation (seeFunctionModelHelper). Rather than introduce a separate allocation function, I took the simpler route of just adding an explicitassumestatement after these two calls.false, several regression tests needed explicitNULL-handling so they don't fail after this change.