Mirror bvugt/bvuge/bvsgt/bvsge onto bvult/bvule/bvslt/bvsle - #799
Open
the-mr-dave wants to merge 3 commits into
Open
Mirror bvugt/bvuge/bvsgt/bvsge onto bvult/bvule/bvslt/bvsle#799the-mr-dave wants to merge 3 commits into
the-mr-dave wants to merge 3 commits into
Conversation
rvinton
marked this pull request as ready for review
August 18, 2026 08:35
the-mr-dave
force-pushed
the
wip/rvde/mirror-greater-comparisons
branch
from
August 26, 2026 10:21
c8426d0 to
4c82a22
Compare
the-mr-dave
commented
Aug 26, 2026
Contributor
Author
There was a problem hiding this comment.
Changes are here
the-mr-dave
commented
Aug 26, 2026
Contributor
Author
There was a problem hiding this comment.
Changes are here
Rewrites the four "greater than" comparisons into their swapped "less than" counterpart instead of implementing constant folding for both directions separately, e.g. (bvugt a b) -> (bvult b a). Halves the number of comparison operators that need their own normal form. Co-authored-by: rvinton <rvinton@users.noreply.github.com>
Covers each of the four "greater than" comparisons being swapped into its "less than" counterpart, plus two guards confirming that constant folding still triggers correctly after the operand swap instead of just rewriting the operator syntactically. Co-authored-by: rvinton <rvinton@users.noreply.github.com>
Uses runUnfTest (UnfTransformer directly) instead of SimplificationTest.runSimplificationTest, matching the workflow already used for the other UnfTransformer-level tests in this class. Co-authored-by: rvinton <rvinton@users.noreply.github.com>
the-mr-dave
force-pushed
the
wip/rvde/mirror-greater-comparisons
branch
from
August 30, 2026 22:31
1832c2e to
c677116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"less than" counterpart (e.g. (bvugt a b) -> (bvult b a)) instead of
implementing constant folding separately for both directions.
form / constant-folding implementation.
constant folding still triggers correctly after the operand swap.