Repository navigation
fix: retain link score fallbacks when preview filters match nothing - #2411
Open
linjiaye929 wants to merge 1 commit into
Open
linjiaye929 wants to merge 1 commit into
linjiaye929 wants to merge 1 commit into
Conversation
linjiaye929
marked this pull request as ready for review
October 16, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When preview filters match no links,
extract_link_heads()returns before applying the existing score fallback. Links with an intrinsic score therefore retaintotal_score=None; the same excluded link gets its fallback if another URL happens to match.Route the empty selection through
_merge_head_data(links, [], config). Filtering still prevents head fetching, and the existing scoring rules are unchanged. This covers the early-return path left outside #1761.Verification
Run
pytest tests/unit/test_link_preview_filter_scoring.py tests/test_merge_head_data_scoring.py.AI assistance was used for implementation and verification.
Hosted checks
At head
56c4ec61fd443247d14f1fdf703aec49e8a7cd4d, the Discord notification workflow isaction_required; there are zero check runs. This does not establish hosted code/test CI passing.