Update chokidar - #34
Conversation
This comment has been minimized.
This comment has been minimized.
|
CI was red on the type-check, but those four TS 5.9 reports conditional-return mismatches on the ternary branches rather than on the Pushed |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`lastIfArray` needs the same `@ts-expect-error` as its siblings, and in `toArray` the directive no longer covered the errors, which TS now reports on the ternary branches instead of the `return`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
be75301 to
061e6c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 906 908 +2
=========================================
+ Hits 906 908 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Initial checklist
Description of changes
Bumps
chokidarfrom^3.0.0to^5.0.0. Types needed two tweaks:FSWatcheris imported as a type (it is no longer a namespace), and
doneis cast becauseerrornow passesunknown. Dropped glob support does not affect us —fileSet.originsare resolved paths. Existing--watchtests cover it.Likely a major, though:
chokidar@5wants Node>= 20.19.0while the readmepromises Node 16 for this line, and #19 was labelled
semver/majorfor the samereason. I left the readme and
enginesalone since dropping Node 16 is yourcall. Happy to hold this for the next major.
Second commit fixes four pre-existing type errors in
lib/parse-argv.jsunderTypeScript 5.9.3 (floating
typescript: ^5.0.0);mainis red without it, sothis PR could not go green. Glad to split it out if you prefer.