Commit f3ca757
docsy(v2): document the two narrative gaps left by four API regens (#1459)
* docsy(v2): document the two narrative gaps left by four API regens
Closes the narrative half of the accumulated api-surface-delta backlog:
docs#1262, #1373, #1424 (DOC-1362) and #1457 (DOC-1447). Four regens, two
gaps.
Enumerating them was most of the work, because the version churn hides the
signal: #1457 alone is 309 files, of which 307 of the 366 added lines are
`version:` frontmatter bumps. Stripping those leaves very little, and most of
what remains was already covered.
## flyte get devbox (new in 2.6.2, DOC-1447)
Verified new rather than reworded: present at released tag v2.6.2
(cli/_get.py:864-895), zero occurrences at v2.6.1. The devbox page taught
start, stop and delete but had no way to answer "did it come up?", which is
the question a reader has at exactly that point in the page. Added as its own
section between starting and configuring, with --no-probes and the
`-of json-raw` form.
## Fetching a report after the run (DOC-1362)
reports.md covered writing a report from inside a task and said nothing about
reading one afterwards. That is a different reader task -- pull a finished
report into a notebook or a CI job -- and it was uncovered.
Documents Run.get_report(), the attempt argument, and the .aio variant. Also
covers the root-action distinction, which is the part most likely to bite:
Run.get_report() returns the ROOT action's report, so a run whose tasks call
other tasks needs Action.get_report() for a nested one. The SDK's own docstring
was amended to redirect readers there, which is the signal that flagged this
delta as material in the first place.
All three signatures verified against v2.6.2 rather than inferred:
Run.get(name), Action.get(run_name=, name=), Run.get_report(attempt=) with a
real .aio attribute.
## What was already covered, recorded so it is not redone
- Artifacts (#1373/#1424's headline delta, 7 new reference pages): shipped
yesterday as the user-guide artifacts section, docs#1454.
- Default pool/queue deletability (#1457): queues.md already documents the new
semantics including the run.default_queue guard.
- TaskTemplate and DeployedAppEnvironment (#1262): already referenced in
how-task-deployment-works.md and how-app-deployment-works.md.
- AsyncFunctionTaskTemplate (#1262): deliberately not documented. Its own
docstring says it is "automatically created when an asynchronous function is
decorated with the task decorator" -- users never write it, so zero narrative
mentions is correct, not a gap.
Co-Authored-By: docsy <docsy@union.ai>
Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>
* docs: fix three defects found reviewing this PR
hf_token_key=None (regen #1424 changed the type to str | None with "Pass None
to prefetch public models anonymously"): prefetching-models still told every
reader to go create a secret, including readers prefetching a public model who
need none. Verified in _hf_model.py:883, where a falsy hf_token_key attaches no
secret to the task.
Action name in the fetch-a-nested-report example: "my-subtask" reads as though
you pass the task's function name. Nested actions are named by
ActionID.new_sub_action_from as base36(md5(parent, inputs hash, task hash, call
seq)), a 25-character generated string, so the example silently fails to
resolve. Replaced with a real generated name and added the discovery command,
flyte get action <run-name>, which the section did not mention.
Note the first fix proposed here was name="a1", on the grounds that a0, a1, ...
is established elsewhere in the docs. It is not: interacting-with-runs shows
only a0 and hedges it as "usually called a0". Only the root is a0, so a1 would
have swapped one wrong example for another.
flyte get devbox version gate: the command is new in 2.6.2 (0 occurrences in
v2.6.1:src/flyte/cli/_get.py, 8 in v2.6.2), and the next section on the same
page gates --devbox at 2.6.1. A 2.6.1 reader following the new section got "no
such command" with no explanation.
Co-Authored-By: docsy <docsy@union.ai>
Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>
---------
Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>
Co-authored-by: docsy <docsy@union.ai>1 parent 10aac29 commit f3ca757
3 files changed
Lines changed: 70 additions & 0 deletions
File tree
- content/user-guide
- apps/serve-and-deploy-apps
- get-started/run-modes
- tasks/task-programming
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
| |||
Lines changed: 25 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
87 | 112 | | |
88 | 113 | | |
89 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
0 commit comments