docsy(v2): document the two narrative gaps left by four API regens - #1459
Merged
Conversation
GHA build & deploy previewBuilt by
Updated automatically on every push. |
ppiegaze
force-pushed
the
docsy/v2-regen-narrative-impact
branch
from
August 19, 2026 14:23
bb26bf3 to
ae49b19
Compare
Closes the narrative half of the accumulated api-surface-delta backlog: docs#1262, #1373, #1424 (DOC-1362) and #1457 (DOC-1447). Four regens, two gaps. Enumerating them was most of the work, because the version churn hides the signal: #1457 alone is 309 files, of which 307 of the 366 added lines are `version:` frontmatter bumps. Stripping those leaves very little, and most of what remains was already covered. ## flyte get devbox (new in 2.6.2, DOC-1447) Verified new rather than reworded: present at released tag v2.6.2 (cli/_get.py:864-895), zero occurrences at v2.6.1. The devbox page taught start, stop and delete but had no way to answer "did it come up?", which is the question a reader has at exactly that point in the page. Added as its own section between starting and configuring, with --no-probes and the `-of json-raw` form. ## Fetching a report after the run (DOC-1362) reports.md covered writing a report from inside a task and said nothing about reading one afterwards. That is a different reader task -- pull a finished report into a notebook or a CI job -- and it was uncovered. Documents Run.get_report(), the attempt argument, and the .aio variant. Also covers the root-action distinction, which is the part most likely to bite: Run.get_report() returns the ROOT action's report, so a run whose tasks call other tasks needs Action.get_report() for a nested one. The SDK's own docstring was amended to redirect readers there, which is the signal that flagged this delta as material in the first place. All three signatures verified against v2.6.2 rather than inferred: Run.get(name), Action.get(run_name=, name=), Run.get_report(attempt=) with a real .aio attribute. ## What was already covered, recorded so it is not redone - Artifacts (#1373/#1424's headline delta, 7 new reference pages): shipped yesterday as the user-guide artifacts section, docs#1454. - Default pool/queue deletability (#1457): queues.md already documents the new semantics including the run.default_queue guard. - TaskTemplate and DeployedAppEnvironment (#1262): already referenced in how-task-deployment-works.md and how-app-deployment-works.md. - AsyncFunctionTaskTemplate (#1262): deliberately not documented. Its own docstring says it is "automatically created when an asynchronous function is decorated with the task decorator" -- users never write it, so zero narrative mentions is correct, not a gap. Co-Authored-By: docsy <docsy@union.ai> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>
hf_token_key=None (regen #1424 changed the type to str | None with "Pass None to prefetch public models anonymously"): prefetching-models still told every reader to go create a secret, including readers prefetching a public model who need none. Verified in _hf_model.py:883, where a falsy hf_token_key attaches no secret to the task. Action name in the fetch-a-nested-report example: "my-subtask" reads as though you pass the task's function name. Nested actions are named by ActionID.new_sub_action_from as base36(md5(parent, inputs hash, task hash, call seq)), a 25-character generated string, so the example silently fails to resolve. Replaced with a real generated name and added the discovery command, flyte get action <run-name>, which the section did not mention. Note the first fix proposed here was name="a1", on the grounds that a0, a1, ... is established elsewhere in the docs. It is not: interacting-with-runs shows only a0 and hedges it as "usually called a0". Only the root is a0, so a1 would have swapped one wrong example for another. flyte get devbox version gate: the command is new in 2.6.2 (0 occurrences in v2.6.1:src/flyte/cli/_get.py, 8 in v2.6.2), and the next section on the same page gates --devbox at 2.6.1. A 2.6.1 reader following the new section got "no such command" with no explanation. Co-Authored-By: docsy <docsy@union.ai> Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>
ppiegaze
marked this pull request as ready for review
August 19, 2026 14:37
ppiegaze
requested review from
EngHabu,
cosmicBboy,
kumare3 and
samhita-alla
as code owners
August 19, 2026 14:37
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds documentation for retrieving generated reports via the remote API, checking devbox status via CLI, and prefetching public HuggingFace models without requiring a token/secret.
Changes:
- Document fetching a run/action report HTML via
Run.get_report()/Action.get_report()(including attempts and async usage). - Add a “Check the devbox status” section documenting
flyte get devboxand output formats. - Clarify that public HF models can be prefetched anonymously with
hf_token_key=None.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| content/user-guide/tasks/task-programming/reports.md | Adds instructions/examples for fetching reports from completed runs/actions via the remote API. |
| content/user-guide/get-started/run-modes/running-devbox.md | Documents flyte get devbox status checks, faster checks, and machine-readable output. |
| content/user-guide/apps/serve-and-deploy-apps/prefetching-models.md | Notes how to prefetch public models without attaching a secret. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+89
to
+90
| > [!NOTE] | ||
| > `flyte get devbox` requires flyte 2.6.2 or later. |
| ## Check the devbox status | ||
|
|
||
| > [!NOTE] | ||
| > `flyte get devbox` requires flyte 2.6.2 or later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the narrative half of the accumulated
docsy:api-surface-deltabacklog: docs#1262, #1373, #1424 (DOC-1362) and #1457 (DOC-1447).Four regens, two gaps in this PR. Enumerating them was most of the work, because version churn buries the signal — #1457 alone is 309 files, of which 307 of the 366 added lines are
version:frontmatter bumps. Strip those and little remains; most of what does was already covered.Gap 1 —
flyte get devbox(new in 2.6.2)Verified new, not reworded: present at released tag v2.6.2 (
cli/_get.py:864-895), zero occurrences at v2.6.1.running-devbox.mdtaughtstart,stopanddeletebut gave no way to answer "did it come up?" — which is the reader's question at exactly that point in the page. Added as its own section between starting and configuring, covering--no-probesandflyte -of json-raw get devbox.Gap 2 — fetching a report after the run
reports.mdcovered writing a report from inside a task and said nothing about reading one afterwards. That is a different reader task (pull a finished report into a notebook or a CI job) and it was uncovered.Documents
Run.get_report(), theattemptargument, and the.aiovariant. It also covers the distinction most likely to bite:Run.get_report()returns the root action's report, so a run whose tasks call other tasks needsAction.get_report()for a nested one. The SDK's own docstring was amended to redirect readers there, and that redirect is what flagged this delta as material in the first place.Signatures verified against v2.6.2, not inferred:
Run.get(name),Action.get(run_name=, name=),Run.get_report(attempt=)with a real.aioattribute.What was already covered — recorded so it is not redone
queues.mdalready documents the new semantics, including therun.default_queueguardTaskTemplate,DeployedAppEnvironment(#1262)how-task-deployment-works.mdandhow-app-deployment-works.mdAsyncFunctionTaskTemplate(#1262)--recover/--recover-from/--force-rerun-action/--allow-missing-outputs(#1373/#1424)main, but claimed: in flight as #1439. Omitting it from this table was the record gap, not the work--tracked/--tracked-strict/--local-tracked(#1424)hf_token_key: str→str | None(#1424)prefetching-models.mdsent readers of public models to create a secret they do not need. Fixed in this PRregister_instrumentoretc. (#1373/#1424)integrations/grafana-agent-observability/flyte.load_plugin_config,flyte.load_interactive_ctx(#1424)The fifth regen (#1442), and why it is not folded in
gh pr list --label "docsy:api-surface-delta"returns #1262, #1283 (v1), #1373, #1424, #1442, #1457. #1442 (2.6.0 → 2.6.1,material) spun DOC-1442, which covered onlyflyte create config --devbox(shipped as #1453). Its other delta was never dispositioned:flyteplugins.ray.AutoscalerOptionsConfig(new page) andRayJobConfig.autoscaler_options(new parameter).integrations/ray/_index.mddocumentsenable_autoscalingbut has noautoscaler_optionsrow, so the knob that configures the feature the page already teaches is undocumented. That is a real gap.It is not folded in here because #1458 is currently editing that same page. Folding it in would collide. It gets its own ticket, sequenced after #1458 merges.
Fixes applied after review
hf_token_key=Nonedocumented onprefetching-models.md_hf_model.py:883: a falsyhf_token_keyattaches no secretAction.get_report()examplename="my-subtask"reads as the task's function name. Nested actions arebase36(md5(...)), a 25-char generated string, so the example could not resolve. Replaced with a real name, plusflyte get action <run-name>to discover itflyte get devboxversion note--devboxat 2.6.1. A 2.6.1 reader hit "no such command"One proposed fix was rejected on verification: the nested-action example was to become
name="a1", on the grounds thata0, a1, …is established elsewhere in the docs. It is not.interacting-with-runs.mdshows onlya0and hedges it as "usually calleda0". Only the root action isa0, soa1would have replaced one wrong example with another.Note on reviewing regen PRs
Two things make these easy to under-review, worth knowing:
filesarray caps at 100, so docs(api-reference): regenerate API docs (automated) #1457's UI file count understated it by 3× (really 309).gh pr diffrefuses above 300 files outright, so the diff has to be taken locally from the base and head SHAs. That is the same threshold at which Copilot structurally opts out of regen PRs — the automated reviewer disappears at exactly the size where a human is least likely to read the diff.— docsy · automated docs agent · DOC-1362 · DOC-1447