Skip to content

rpc: do not abort on shutdown when a teardown round trip fails #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielhanchen wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rpc: do not abort on shutdown when a teardown round trip fails #203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e13caa
rpc: do not abort on shutdown when a teardown round trip fails
danielhanchen Sep 6, 2026
8e9c042
rpc: trim comments in the teardown abort fix
danielhanchen Sep 9, 2026
c96b2c9
tighten the comments added by this change
danielhanchen Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ggml/src/ggml-rpc/ggml-rpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,10 @@ static std::shared_ptr<socket_t> get_socket(const std::string & endpoint) {
static void ggml_backend_rpc_buffer_free_buffer(ggml_backend_buffer_t buffer) {
ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;
rpc_msg_free_buffer_req request = {ctx->remote_ptr};
bool status = send_rpc_cmd(ctx->sock, RPC_CMD_FREE_BUFFER, &request, sizeof(request), nullptr, 0);
RPC_STATUS_ASSERT(status);
// teardown: if the peer is gone, so is the buffer. Never abort here.
if (!send_rpc_cmd(ctx->sock, RPC_CMD_FREE_BUFFER, &request, sizeof(request), nullptr, 0)) {
GGML_LOG_ERROR("%s: failed to free the remote buffer, the connection is gone\n", __func__);
}
delete ctx;
}

Expand Down Expand Up @@ -823,24 +825,31 @@ bool ggml_backend_is_rpc(ggml_backend_t backend) {
return backend != NULL && ggml_guid_matches(backend->guid, ggml_backend_rpc_guid());
}

static void get_device_memory(const std::shared_ptr<socket_t> & sock, uint32_t device, size_t * free, size_t * total) {
static bool get_device_memory(const std::shared_ptr<socket_t> & sock, uint32_t device, size_t * free, size_t * total) {
rpc_msg_get_device_memory_req request;
request.device = device;
rpc_msg_get_device_memory_rsp response;
bool status = send_rpc_cmd(sock, RPC_CMD_GET_DEVICE_MEMORY, &request, sizeof(request), &response, sizeof(response));
RPC_STATUS_ASSERT(status);
if (!send_rpc_cmd(sock, RPC_CMD_GET_DEVICE_MEMORY, &request, sizeof(request), &response, sizeof(response))) {
return false;
}
*free = response.free_mem;
*total = response.total_mem;
return true;
}

void ggml_backend_rpc_get_device_memory(const char * endpoint, uint32_t device, size_t * free, size_t * total) {
*free = 0;
*total = 0;
auto sock = get_socket(endpoint);
if (sock == nullptr) {
return;
}
// informational, queried at teardown when the peer may be gone: report 0, as an unreachable endpoint does.
if (!get_device_memory(sock, device, free, total)) {
GGML_LOG_ERROR("%s: failed to query device memory of %s, reporting 0\n", __func__, endpoint);
*free = 0;
*total = 0;
return;
}
get_device_memory(sock, device, free, total);
}

// RPC server-side implementation
Expand Down