Repin Inkling to the commit that compiles against the new base - #207
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin
ggml-org/llama.cpp#25731(TML Inkling) from36df1bf4to1066edc3.Why
Run
34108333979got past every merge for the first time, then failed a later gate:This one is more interesting than the previous two repins, because the merge was
clean and still wrong. Both sides appended to the same enum and both took slot 57:
additive_merge.pydid exactly what it says it does: the merge base was empty atthat point, both sides only added, so it kept both. That is a pure add/add by
content, and it is still a defect, because the two additions carry the same
explicit value. The union of two
casearms that share a value does not compile.Resolved by keeping upstream's numbering and moving ours:
INKLING = 59. Upstream'svalues are the ones in released builds, so ours is the one that should move. The
pre-type is resolved from the tokenizer string at load time and is not serialised
into the GGUF, so renumbering does not affect existing model files.
The same commit also takes the
llama-model.cpparm forSPARK2_5alongside oursfor
INKLING, which is a genuine add/add.Verification
libllama.so,llama-commonandtest-llama-archsall build clean against themerged tree, and
test-llama-archsexits 0. That is the specific gate that failedin CI, reproduced locally before pushing.
Worth noting for the merge tooling
Three repins in a row now, all from the base advancing under pinned PRs:
test-llama-archs.cpptest-llama-archs.cppThe third is the one to take seriously: it shows a clean additive merge is not
sufficient evidence of correctness, and the compile gate is what caught it. That
gate is doing real work and should stay. I would not extend
additive_merge.pytounderstand enum numbering; the cheaper and more honest position is that the compile
check is the backstop, which is exactly how it behaved here.