Repin GLM-5-Next (#27754) to the head that builds under fatal warnings - #212
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nightly run 34412786914 (base b10881) did not publish: both macOS legs failed in the build step and assemble refused to publish.
Upstream deprecated the precision setters in ggml-org#26675, and the macOS prebuilt legs build with
LLAMA_FATAL_WARNINGS=ONunder clang. The offending file comes from pin 6, ggml-org#27754 (branchunslothai:glm5next/upstream), which was 252 commits behind upstream master.What changed on the pin
2af9da2d5merges upstream master intoglm5next/upstream(clean, no conflicts).d94f44e79switches the one call atsrc/models/glm5next.cpp:412toggml_prec_set_acc(w, GGML_PREC_F32). Same op_params slot, same F32 accumulation for the indexer weights.This PR moves
scripts/unsloth/pr-set.jsonentry 6 fromb9b8207fctod94f44e79.Evidence
llama,llama-cli,test-llama-archsbuild clean;test-llama-archs -a glm5next -s 1234reports OK (0.00e+00).merge_checks.pyclean,pin_contract.pyOK, mix headee659afe2.grepover the mixed tree forggml_mul_mat_set_prec(andggml_flash_attn_ext_set_prec(outside the ggml headers: zero call sites left.After merge
Tonight's schedule picks up master. To recover the b10881 release earlier, re-run the failed jobs of run 34412786914 after this lands.