still-to-try: read the Guests lines from the grant rows, not the change log

The change log is pruned at 90 days and postdates some accounts, so a
household that printed a QR and sent a pass months ago was still told to
try both. The three Guests lines now read the durable guest_grant rows by
kind, with the log as a second opinion.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0121j6qgGwUSLGQ48jWZN98F

Author: uppertoe

internal/server/checklist.go

@@ -70,10 +70,14 @@ func (s *Server) checklistFor(ctx context.Context, owner, user string, isPrimary
 			{Label: "Add an email, so they are told when their rego goes on the permit", Href: "#add", Done: email},
 		}
 	case "guests":
+		// The grant rows outlive the change log (pruned at 90 days, and younger than
+		// some accounts), so each line reads the durable row first and the log only
+		// as a second opinion.
+		passes, printed, shown, _ := s.store.GuestGrantKinds(ctx, owner)
 		items = []checkItem{
-			{Label: "Show a visitor QR to someone at the door", Href: "#now", Done: did(store.ActionDoorQRShow)},
-			{Label: "Send a guest pass to a household that visits often", Href: "#new", Done: did(store.ActionGuestCreate)},
-			{Label: "Print a QR that pings your phone when it is used", Href: "#now", Done: did(store.ActionDoorQRCreate)},
+			{Label: "Show a visitor QR to someone at the door", Href: "#now", Done: shown > 0 || did(store.ActionDoorQRShow)},
+			{Label: "Send a guest pass to a household that visits often", Href: "#new", Done: passes > 0 || did(store.ActionGuestCreate)},
+			{Label: "Print a QR that pings your phone when it is used", Href: "#now", Done: printed > 0 || did(store.ActionDoorQRCreate)},
 		}
 	case "settings":
 		permits, _ := s.store.ListPermitsFor(ctx, owner)

internal/store/guests.go

@@ -365,6 +365,18 @@ WHERE gv.grant_id = ? ORDER BY v.label, v.registration`, gc.Grant.ID)
 }
 
 // ListGuestGrants returns the owner's grants with their cars and recipient tokens.
+// GuestGrantKinds counts the account's grants by kind: emailed passes, printed
+// (request-only) QRs and on-screen visitor QRs. The rows are durable where the
+// change log is pruned, so "has this household ever used X" is read from here.
+func (s *Store) GuestGrantKinds(ctx context.Context, owner string) (passes, printed, onScreen int, err error) {
+	err = s.db.QueryRowContext(ctx, `
+SELECT COALESCE(SUM(on_screen = 0 AND request_only = 0), 0),
+       COALESCE(SUM(request_only = 1), 0),
+       COALESCE(SUM(on_screen = 1), 0)
+FROM guest_grant WHERE owner = ?`, owner).Scan(&passes, &printed, &onScreen)
+	return
+}
+
 func (s *Store) ListGuestGrants(ctx context.Context, owner string) ([]GuestGrantDetail, error) {
 	rows, err := s.db.QueryContext(ctx,
 		`SELECT id, permit_id, label, allow_overnight, enabled, created_at FROM guest_grant WHERE owner = ? AND on_screen = 0 AND request_only = 0 ORDER BY id DESC`, owner)