fix(urunc-deploy): use the host architecture for the QEMU path in config.toml - #1009
Open
aman21-droid wants to merge 1 commit into
Open
fix(urunc-deploy): use the host architecture for the QEMU path in config.toml#1009aman21-droid wants to merge 1 commit into
aman21-droid wants to merge 1 commit into
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cmainas
reviewed
Sep 2, 2026
cmainas
left a comment
Contributor
There was a problem hiding this comment.
Hello @aman21-droid ,
thank you for the fix. Just one small comment.
aman21-droid
force-pushed
the
fix/urunc-deploy-qemu-arch
branch
from
September 2, 2026 07:08
937d63c to
06cb428
Compare
cmainas
reviewed
Sep 2, 2026
cmainas
left a comment
Contributor
There was a problem hiding this comment.
Thank you @aman21-droid for the quick fix. Please squash your commits so we can merge this.
aman21-droid
force-pushed
the
fix/urunc-deploy-qemu-arch
branch
from
September 2, 2026 07:45
06cb428 to
7965589
Compare
Author
|
done |
Signed-off-by: aman21-droid <amanarora.smn@gmail.com>
aman21-droid
force-pushed
the
fix/urunc-deploy-qemu-arch
branch
from
September 2, 2026 08:37
7965589 to
b54b3a5
Compare
Author
|
@cmainas the CI runs are sitting in awaiting approval after the force-push — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On arm64 nodes urunc-deploy installed the QEMU binary as
qemu-system-aarch64but wroteqemu-system-x86_64into/etc/urunc/config.toml, so QEMU backed containers could not start.install_artifactsusesqemu-system-$(uname -m)while the path inconfig.tomlwas fixed tox86_64, and
install_urunc_configcopied that file to the host unchanged.config.tomlnow carries a@QEMU_BINARY@placeholder on the QEMU path line, andinstall_urunc_configsubstitutesqemu-system-$(uname -m)as it copies the file.Also adds
deployment/urunc-deploy/config.tomlto thepaths:list inbuild-trigger.yml. TheDockerfile COPYs that file into the image, but a change to it alone would not have triggered a
rebuild.
Related issues
How was this tested?
Ran the real
install.shagainst a reconstructed image layout withuname -mreturning eacharchitecture:
qemu-system-aarch64, configures/opt/urunc/bin/qemu-system-aarch64qemu-system-x86_64, configures/opt/urunc/bin/qemu-system-x86_64The x86_64 output is byte identical to the config that shipped before this change, so there is no
behaviour change on amd64.
Fed the generated arm64 config to a locally built urunc and ran create/start on a qemu bundle. The
previous error is gone:
urunc now gets past the mount stage and reaches the monitor execve.
I do not have arm64 hardware, so the architecture-dependent half was exercised by controlling
uname -mrather than on a real arm64 node. The runtime half does not depend on hostarchitecture, it is a path that does not resolve.
LLM usage
Claude opus investigating the bug and fixes.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).