fix(config): keep extra binary defaults on partial decode - #1015
Open
magic-peach wants to merge 2 commits into
Open
fix(config): keep extra binary defaults on partial decode#1015magic-peach wants to merge 2 commits into
magic-peach wants to merge 2 commits into
Conversation
A partial [extra_binaries.<name>] section zeroes the fields it omits, dropping the seeded defaults the same way monitors used to. Reapply them the same way. Fixes: urunc-dev#1010 Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
✅ Deploy Preview for urunc canceled.
|
cmainas
reviewed
Sep 2, 2026
cmainas
left a comment
cmainas
left a comment
Contributor
There was a problem hiding this comment.
Hello @magic-peach ,
thank you for the PR. Just one comment to remove the unnecessary loop.
Only virtiofsd is a supported extra binary today, so drop the loop over all configured entries in favor of checking it directly, as suggested in review. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
magic-peach
force-pushed
the
fix/1010-extrabins-defaults
branch
from
September 2, 2026 11:13
c12fea2 to
074a455
Compare
Author
|
Done @cmainas i replaced the loop with a direct virtiofsd check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LoadUruncConfig reapplies default values for a partially specified [monitors.name] section, but had no equivalent for [extra_binaries.name]. A partial extra binaries section (e.g. one that only sets path) silently lost the default options. This adds the same defaulting for extra binaries.
Related issues
How was this tested?
Added a unit test in urunc_config_test.go covering a partial [extra_binaries.virtiofsd] section that only sets path, asserting the default options value is kept. Ran go build, go vet, and go test for pkg/unikontainers, and golangci-lint run for the package, all clean.
LLM usage
none
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).