Skip to content

fix[installer](proxy): speak grpcs to agent-manager and log-input - #2513

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_agent_manager_protocol
Aug 26, 2026
Merged

fix[installer](proxy): speak grpcs to agent-manager and log-input#2513
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_agent_manager_protocol

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

🛑 AI review — Sensitive area, extra care recommended

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. Review carefully before merging.

🛑 architecture (gemini-3-flash-lite) — high/critical — please review

Summary: Changes in installer templates modify gRPC proxying from plaintext to TLS (grpcs), breaking existing agent communication.

  • high installer/templates/front-end.go:74 — Switching agent gRPC endpoints from grpc:// to grpcs:// in the Nginx template forces TLS without providing a fallback or maintaining backwards compatibility for existing deployed agents, resulting in an agent-breaking change.

bugs (gemini-3-flash-lite) — clean

Summary: Nginx template updated to use grpcs for gRPC proxy locations with ssl verification disabled.

No findings.

🛑 security (gemini-3-flash-lite) — high/critical — please review

Summary: Diff touches security-critical paths (nginx TLS configuration/installer templates for gRPC proxying).

No findings.

🔴 go-deps — pending updates

🔍 Discovered 30 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/crowdstrike:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/azure:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/soc-ai:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/events:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/gcp:
     - cloud.google.com/go/pubsub: v1.51.0 → v1.51.1
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/api: v0.293.0 → v0.294.0

  📁 ./plugins/bitdefender:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/o365:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/rule-flood-guard:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/stats:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/feeds:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/geolocation:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/playground:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/soar:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/sophos:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/alerts:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2: v1.43.6 → v1.44.0
     - github.com/aws/aws-sdk-go-v2/config: v1.32.37 → v1.32.40
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.36 → v1.19.39
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.82.2 → v1.83.0
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./log-input:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./backend:
     - cloud.google.com/go/pubsub: v1.51.0 → v1.51.1
     - github.com/aws/aws-sdk-go-v2/config: v1.32.36 → v1.32.40
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.35 → v1.19.39
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.45.5 → v1.46.0
     - google.golang.org/api: v0.293.0 → v0.294.0
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./collectors/collector:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./collectors/forwarder:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./collectors/as400:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./collectors/utmstack:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./tools/rulecheck:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./agent-manager:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

  📁 ./agent:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - google.golang.org/grpc: v1.83.0 → v1.83.2

❌ Please update dependencies before merging.

@AlexSanchez-bit
AlexSanchez-bit force-pushed the backlog/v12_agent_manager_protocol branch from 49e4cfc to 69659d6 Compare August 26, 2026 20:24
@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

grpcs is needed so tls is executed on the agent manager connections

@AlexSanchez-bit
AlexSanchez-bit merged commit 450a7fd into release/v12.0.0 Aug 26, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_agent_manager_protocol branch August 26, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant