feat(plugins): distribute ingestion ownership across event-processor workers - #2521
Merged
Merged
Conversation
✅ AI review — CleanNo issues detected in this diff. ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The four pull-based ingestion plugins (aws, o365, crowdstrike, sophos) now run in
worker mode and coordinate ownership over NATS JetStream, so multiple
event-processor replicas no longer duplicate or drop work.
plugins/sharedmodule: lease store, cursor store, job queue, scheduler.streaming, renews it on a heartbeat, and stops as soon as it is fenced.
per tick; any worker may consume it.
per-group cursor.
Why
Each replica used to run the full ingestion loop independently, and the position
lived in a local variable: on restart a plugin resumed at
now - interval, soanything that arrived while it was down was never read. Persisting the cursor
lets a replica resume where the previous one stopped; the lease and queue paths
decide which replica does the work.
On failover the design prefers re-reading over skipping — a duplicate is noise,
a gap is an attack nobody saw. Deterministic event ids are what keep those
re-reads recognisable.