Skip to content

test(tail): fix follow name truncate failing on macos - #14438

Open
eduardomourar wants to merge 1 commit into
uutils:mainfrom
eduardomourar:failing-test-tail-follow-name-truncate
Open

test(tail): fix follow name truncate failing on macos#14438
eduardomourar wants to merge 1 commit into
uutils:mainfrom
eduardomourar:failing-test-tail-follow-name-truncate

Conversation

@eduardomourar

@eduardomourar eduardomourar commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Fixes: #12335

test_follow_name_truncate1 used fixed sleeps between spawning tail and truncating/restoring the watched file, which raced against a slow-starting child process on macOS CI and could miss both events entirely.

Replaced the pre-mutation delay with a wait for tail's initial output, which is only printed after the file watcher is registered — making the test deterministic instead of probabilistic.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 153.09 MB (+904 KB, +0.58%)

Significant per-binary changes:
  expr     2.76 MB ->    3.65 MB  (+908 KB, +32.11%)

@eduardomourar
eduardomourar force-pushed the failing-test-tail-follow-name-truncate branch from 240995c to dde83c2 Compare September 7, 2026 17:28
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_follow_name_truncate1 failure

1 participant