test(tail): fix follow name truncate failing on macos - #14438
Open
eduardomourar wants to merge 1 commit into
Open
test(tail): fix follow name truncate failing on macos#14438eduardomourar wants to merge 1 commit into
eduardomourar wants to merge 1 commit into
Conversation
|
Binary size comparison: |
eduardomourar
force-pushed
the
failing-test-tail-follow-name-truncate
branch
from
September 7, 2026 17:28
240995c to
dde83c2
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12335
test_follow_name_truncate1used fixed sleeps between spawning tail and truncating/restoring the watched file, which raced against a slow-starting child process on macOS CI and could miss both events entirely.Replaced the pre-mutation delay with a wait for tail's initial output, which is only printed after the file watcher is registered — making the test deterministic instead of probabilistic.