[v8] Migrate callback data accessors to DataV2()

Use explicit Value casts for callback data that is known to contain
JavaScript values, and pass Data directly where supported.

Refs: https://issues.chromium.org/issues/559925519

Author: deepak1556

doc/api/addons.md

@@ -214,7 +214,7 @@ class AddonData {
 static void Method(const v8::FunctionCallbackInfo<v8::Value>& info) {
   // Retrieve the per-addon-instance data.
   AddonData* data =
-      reinterpret_cast<AddonData*>(info.Data().As<External>()->Value());
+      reinterpret_cast<AddonData*>(info.DataV2().As<External>()->Value());
   data->call_count++;
   info.GetReturnValue().Set((double)data->call_count);
 }
@@ -982,7 +982,7 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
     const int argc = 1;
     Local<Value> argv[argc] = { args[0] };
     Local<Function> cons =
-        args.Data().As<Object>()->GetInternalField(0)
+        args.DataV2().As<Value>().As<Object>()->GetInternalField(0)
             .As<Value>().As<Function>();
     Local<Object> result =
         cons->NewInstance(context, argc, argv).ToLocalChecked();

src/js_native_api_v8.cc

@@ -402,7 +402,7 @@ class CallbackBundle {
     return cbdata;
   }
 
-  static CallbackBundle* FromCallbackData(v8::Local<v8::Value> data) {
+  static CallbackBundle* FromCallbackData(v8::Local<v8::Data> data) {
     return reinterpret_cast<CallbackBundle*>(
         data.As<v8::External>()->Value(v8::kExternalPointerTypeTagDefault));
   }
@@ -491,7 +491,7 @@ class FunctionCallbackWrapper {
   explicit FunctionCallbackWrapper(
       const v8::FunctionCallbackInfo<v8::Value>& cbinfo)
       : cbinfo_(cbinfo),
-        bundle_(CallbackBundle::FromCallbackData(cbinfo.Data())) {}
+        bundle_(CallbackBundle::FromCallbackData(cbinfo.DataV2())) {}
 
   void InvokeCallback() {
     napi_callback_info cbinfo_wrapper =

src/module_wrap.cc

@@ -1259,7 +1259,7 @@ static void ImportMetaResolveLazyGetter(
 
   // This should be createImportMetaResolve(). The loader argument is already
   // bound at initialization time.
-  Local<Value> args[] = {info.Data()};
+  Local<Value> args[] = {info.DataV2().As<Value>()};
   Local<Value> ret;
   if (!initializer
            ->Call(context, Undefined(realm->isolate()), arraysize(args), args)
@@ -1290,7 +1290,7 @@ static void PathHelpersLazyGetter(Local<v8::Name> name,
   }
   Environment* env = Environment::GetCurrent(context);
 
-  node::Utf8Value url(isolate, info.Data());
+  node::Utf8Value url(isolate, info.DataV2().As<Value>());
   auto file_url = ada::parse(url.ToStringView());
   CHECK(file_url);
   auto file_path = url::FileURLToPath(env, *file_url);

src/node_ffi.cc

@@ -509,7 +509,8 @@ void DynamicLibrary::Close(const FunctionCallbackInfo<Value>& args) {
 
 void DynamicLibrary::InvokeFunction(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
-  FFIFunctionInfo* info = Unwrap<FFIFunctionInfo>(args.Data());
+  FFIFunctionInfo* info =
+      Unwrap<FFIFunctionInfo>(args.DataV2().As<Value>());
   CHECK_NOT_NULL(info);
   FFIFunction* fn = info->fn.get();
 
@@ -578,7 +579,8 @@ void DynamicLibrary::InvokeFunction(const FunctionCallbackInfo<Value>& args) {
 
 void DynamicLibrary::InvokeFunctionSB(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
-  FFIFunctionInfo* info = Unwrap<FFIFunctionInfo>(args.Data());
+  FFIFunctionInfo* info =
+      Unwrap<FFIFunctionInfo>(args.DataV2().As<Value>());
   CHECK_NOT_NULL(info);
   FFIFunction* fn = info->fn.get();
 

src/node_locks.cc

@@ -129,7 +129,7 @@ static void OnLockCallbackFulfilled(const FunctionCallbackInfo<Value>& info) {
   Environment* env = Environment::GetCurrent(info);
 
   BaseObjectPtr<LockHolder> lock_holder{
-      BaseObject::FromJSObject<LockHolder>(info.Data())};
+      BaseObject::FromJSObject<LockHolder>(info.DataV2().As<Value>())};
   std::shared_ptr<Lock> lock = lock_holder->lock();
 
   // Release the lock and continue processing the queue.
@@ -143,7 +143,7 @@ static void OnLockCallbackRejected(const FunctionCallbackInfo<Value>& info) {
   Environment* env = Environment::GetCurrent(info);
 
   BaseObjectPtr<LockHolder> lock_holder{
-      BaseObject::FromJSObject<LockHolder>(info.Data())};
+      BaseObject::FromJSObject<LockHolder>(info.DataV2().As<Value>())};
   std::shared_ptr<Lock> lock = lock_holder->lock();
 
   LockManager::GetCurrent()->ReleaseLockAndProcessQueue(
@@ -153,13 +153,13 @@ static void OnLockCallbackRejected(const FunctionCallbackInfo<Value>& info) {
 // Called when the promise returned from the user's callback resolves
 static void OnIfAvailableFulfill(const FunctionCallbackInfo<Value>& info) {
   HandleScope handle_scope(info.GetIsolate());
-  USE(info.Data().As<Promise::Resolver>()->Resolve(
+  USE(info.DataV2().As<Value>().As<Promise::Resolver>()->Resolve(
       info.GetIsolate()->GetCurrentContext(), info[0]));
 }
 
 // Called when the promise returned from the user's callback rejects
 static void OnIfAvailableReject(const FunctionCallbackInfo<Value>& info) {
-  USE(info.Data().As<Promise::Resolver>()->Reject(
+  USE(info.DataV2().As<Value>().As<Promise::Resolver>()->Reject(
       info.GetIsolate()->GetCurrentContext(), info[0]));
 }
 

src/node_util.cc

@@ -379,7 +379,7 @@ static void DefineLazyPropertiesGetter(
   }
 
   Realm* realm = Realm::GetCurrent(context);
-  Local<Value> arg = info.Data();
+  Local<Value> arg = info.DataV2().As<Value>();
   Local<Value> require_result;
   if (!realm->builtin_module_require()
            ->Call(context, Null(isolate), 1, &arg)

src/node_wasm_web_api.cc

@@ -157,7 +157,7 @@ void StartStreamingCompilation(const FunctionCallbackInfo<Value>& info) {
 
   // Create the wrapper object.
   std::shared_ptr<WasmStreaming> streaming =
-      WasmStreaming::Unpack(info.GetIsolate(), info.Data());
+      WasmStreaming::Unpack(info.GetIsolate(), info.DataV2());
   Environment* env = Environment::GetCurrent(info);
   Local<Object> obj;
   if (!WasmStreamingObject::Create(env, streaming).ToLocal(&obj)) {

test/addons/worker-addon-exit/binding.cc

@@ -72,7 +72,8 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
     // Invoked as plain function `MyObject(...)`, turn into construct call.
     const int argc = 1;
     Local<Value> argv[argc] = {args[0]};
-    Local<Function> cons = args.Data()
+    Local<Function> cons = args.DataV2()
+                               .As<Value>()
                                .As<Object>()
                                ->GetInternalField(0)
                                .As<Value>()

test/cctest/test_environment.cc

@@ -415,7 +415,7 @@ TEST_F(EnvironmentTest, RunAndClearNativeImmediatesSkipsEmptyScope) {
           context,
           [](const v8::FunctionCallbackInfo<v8::Value>& info) {
             IntVec* callback_calls =
-                static_cast<IntVec*>(info.Data().As<v8::External>()->Value(
+                static_cast<IntVec*>(info.DataV2().As<v8::External>()->Value(
                     v8::kExternalPointerTypeTagDefault));
             callback_calls->push_back(info[0].As<v8::Int32>()->Value());
           },
@@ -772,7 +772,7 @@ TEST_F(EnvironmentTest, NestedMicrotaskQueue) {
           context,
           [](const v8::FunctionCallbackInfo<v8::Value>& info) {
             IntVec* callback_calls =
-                static_cast<IntVec*>(info.Data().As<v8::External>()->Value(
+                static_cast<IntVec*>(info.DataV2().As<v8::External>()->Value(
                     v8::kExternalPointerTypeTagDefault));
             callback_calls->push_back(info[0].As<v8::Int32>()->Value());
           },